Skip to content

karakeep-install: Disable Playwright browser download, remove MCP build #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

vhsdream
Copy link
Member

@vhsdream vhsdream commented Jul 8, 2025

✍️ Description

  • changes export during install to disable automatic browser downloading by Playwright
  • removes yarn
  • removes MCP build
  • performs pnpm store prune after install/update to remove extraneous packages

🔗 Related PR / Issue

Link: #5697

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@vhsdream vhsdream requested a review from a team as a code owner July 8, 2025 13:44
@github-actions github-actions bot added the update script A change that updates a script label Jul 8, 2025
@CrazyWolf13
Copy link
Member

what is mcp and why remove it?

@vhsdream
Copy link
Member Author

vhsdream commented Jul 8, 2025

It's the Model Context Protocol server and apparently does not need to be built for our use-case. Doesn't really save space or anything but I think it's good to have this script have parity with the install script in the Karakeep repo.

@vhsdream
Copy link
Member Author

vhsdream commented Jul 8, 2025

For some reason I didn't notice that the Karakeep repo script has "true instead of 1 as the playwright export; changed it here, as well as added the export to the update script so it doesn't pull the browser on an update.

@vhsdream vhsdream marked this pull request as draft July 8, 2025 14:42
@vhsdream vhsdream self-assigned this Jul 8, 2025
@github-actions github-actions bot added core high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project labels Jul 8, 2025
@tremor021 tremor021 requested a review from MickLesk July 8, 2025 20:42
@vhsdream vhsdream force-pushed the karakeep branch 10 times, most recently from 07e73a6 to 07924db Compare July 15, 2025 16:45
…ywright browser download

- add pnpm store prune to install and update to free some more space
@vhsdream vhsdream force-pushed the karakeep branch 2 times, most recently from b4f9d7f to eb95304 Compare July 15, 2025 17:35
@vhsdream
Copy link
Member Author

OK this is ready finally, but I won't take off draft until the next Karakeep update is out.

@MickLesk
Copy link
Member

Any eta?

@vhsdream
Copy link
Member Author

Your guess is as good as mine 😉

@MickLesk
Copy link
Member

MickLesk commented Jul 15, 2025

@MohamedBassem ? 😄

@MohamedBassem
Copy link
Contributor

@vhsdream why do you need to wait for the next release? If you keep both puppeteer/playwright skip downloads, we should be good to go right?

That being said, I'm aiming for a release this weekend, but I recommend not waiting for it.

MickLesk
MickLesk previously approved these changes Jul 16, 2025
MickLesk
MickLesk previously approved these changes Jul 16, 2025
@vhsdream vhsdream marked this pull request as ready for review July 16, 2025 10:45
@vhsdream vhsdream requested a review from MickLesk July 16, 2025 10:53
@MickLesk MickLesk removed maintenance Code maintenance or general upkeep of the project high risk A change that can affect many scripts core labels Jul 16, 2025
@tremor021 tremor021 merged commit dafb4af into community-scripts:main Jul 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants