Fixed the previous fix of the anti-nag hook #6095
Draft
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Yesterday's fix of the anti-nag apt hook had some unintended side effects as reported today by @memesalot and @vsc55 in #6078. This PR fixes this. What is being done in particular:
&&
chaining is replaced back with an if-condition because otherwise the hook returns with a non-0 exit code when JS patching is not needed andapt
scares users with an error messagedpkg -V
check has been replaced with agrep -F
check to avoid stdout leaking??5?????? /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js
(I couldn't reproduce that on my installs, glad others helped with testing)Draft until this concern by @vsc55 is resolved:
🔗 Related PR / Issue
Link: #6078
Link: #6084
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.