Skip to content

Scraparr #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 30, 2025
Merged

Scraparr #634

merged 15 commits into from
Jun 30, 2025

Conversation

JasonGreenC
Copy link
Contributor

@JasonGreenC JasonGreenC commented Jun 27, 2025 •
edited
Loading

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Added a new script to spin up an LXC container for Scraparr - a Prometheus exporter for *arr applications.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

First time contributing to this project - please let me know if I messed anything up! The app itself is simple but given that I recently overhauled my lab and wanted this I figured I would share my install in case others want this.

@JasonGreenC JasonGreenC requested review from a team as code owners June 27, 2025 04:26
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
tremor021
tremor021 reviewed Jun 27, 2025
View reviewed changes
JasonGreenC and others added 13 commits June 27, 2025 08:07
@JasonGreenC @tremor021
Convert deployment to use fetch_and_deploy_gh_release function.
da932c0 
Co-authored-by: Slaviša Arežina <[email protected]>
@JasonGreenC @tremor021
Convert deployment to use fetch_and_deploy_gh_release function.
6bb213e 
Co-authored-by: Slaviša Arežina <[email protected]>
@JasonGreenC @tremor021
Added documentation link to frontend json
271e863 
Added documentation link to frontend json

Co-authored-by: Slaviša Arežina <[email protected]>
Updated frontend json interface port
66b4ff5
uvenv mgiration
ea1cbfe
fixed build links for dev
39eef6e
fixed build links for dev
16bea48
fixed build links for dev
57327ec
fixed build links for dev
e00e6c6
revert build links for prod
80cb9b3
Convert deployment to use python uv. Cleaned up some formatting issue…
e9888ce 
…s Added jsdelivr cdn link for logo.
Added completation message
5e5f22f
@JasonGreenC
Merge pull request #1 from JasonGreenC/scraparr-uv-migration
2d6c220 
Added requested functionality and cleanup suggestions.
@tremor021
Copy link
Member

tremor021 commented Jun 28, 2025 •
edited
Loading

Very good Jason, just remove build.func and install.func from the PR please. We can merge after you do that, so we can test it properly

@JasonGreenC
Copy link
Contributor Author

!! Thought I ignored those - should be updated!

tremor021
tremor021 approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@tremor021 tremor021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@community-scripts/contributor we can merge this for testing

tremor021
tremor021 approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@tremor021 tremor021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@community-scripts/contributor we can merge this for testing

@MickLesk MickLesk mentioned this pull request Jun 30, 2025
Open
@MickLesk MickLesk merged commit 5711fae into community-scripts:main Jun 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyWolf13 CrazyWolf13 CrazyWolf13 left review comments

@tremor021 tremor021 tremor021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonGreenC @tremor021 @CrazyWolf13 @MickLesk