Jf/standardize cpp params #61
Open
+574
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Douglas-Peucker simplification in C++ - AABB tree batch closest point queries (CGAL) - Python wrapper with tests
Co-authored-by: Copilot <[email protected]>
- subdivision: pass-by-value → Eigen::Ref<const> - straight_skeleton_2: const& → Eigen::Ref<const> - triangulation: Eigen::Ref → Eigen::Ref<const> - meshing: remove extra & on Eigen::Ref, add const eliminates unnecessary copies, ~240KB+ per call for large datasets
Collaborator
Author
Collaborator
Author
|
hi @petrasvestartas I guess this is about applying the architecture you developed with foolish consistency |
Collaborator
|
Since multiple files were changed, we need to merge to see if this works locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of #59