fix(ci): make weekly tests pass without Jekyll build artifacts#15
Merged
fix(ci): make weekly tests pass without Jekyll build artifacts#15
Conversation
- make _site optional in simple-test.js for CI runs that do not build Jekyll - exclude bundled MathJax asset from JS lint to avoid false failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Weekly Tests was failing in
npm testbecausescripts/simple-test.jsrequired_site/to exist, but the weekly workflow runs on a fresh checkout and does not run a Jekyll build.After fixing that assertion, lint would still fail on bundled vendor code in
assets/js/mathjax/tex-svg.js(minified third-party file not suitable for repo lint rules).Changes
_siteoptional inscripts/simple-test.jsfor source-only CI runsassets/js/search_db.jsoncheck in placelint:jsscript to ignoreassets/js/mathjax/**and suppress ignore warningsValidation
npm test✅npm run lint✅This is a minimal CI-targeted fix; deployment behavior is unchanged.