Merged
Conversation
The changes remove the duplicate loading of the `command-data.js` script in the `team.html` layout. This script is already loaded in the page's `<head>`, so there's no need to load it again. Additionally, the changes update the `id` of a command palette command from `email-team` to `contact-team` to better reflect its purpose of allowing users to contact the team.
This change adds an accessible name (aria-label) to all email copy buttons on the website. This ensures that screen readers can properly announce the purpose of the button, which is to copy the email address.
The changes include:
- Adding an `aria-label` attribute to the email copy buttons in the HTML files, with the value "Copy email address {email_address}".
- Dynamically adding the `aria-label` attribute to any copy buttons that don't have it on the `DOMContentLoaded` event in the JavaScript file.
This improves the accessibility of the website for users who rely on screen readers or other assistive technologies.
The changes add `aria-label` attributes to the social media links in the footer of the `teaching-course.html`, `default.html`, `teaching.html`, and `team.html` layouts. This improves the accessibility of the website by providing descriptive labels for screen readers.
This commit introduces the following changes: 1. Adds an `aria-label` attribute to the YouTube channel link to provide a more descriptive label for screen readers. 2. Adds an `aria-label` attribute to the GitHub repository link to provide a more descriptive label for screen readers. 3. Adjusts the styling of the GitHub repository link to make it more visually consistent with the rest of the page. These changes improve the accessibility and visual consistency of the website, making it more user-friendly for all visitors.
BREAKING CHANGE: The search command has been removed from the command palette. Search functionality is now available separately via the ⌘K shortcut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the following changes:
command-data.jsscript in theteam.htmllayout. The script is already loaded in the page's<head>, so there's no need to load it again.idof a command palette command fromemail-teamtocontact-teamto better reflect its purpose of allowing users to contact the team.aria-labelattributes to the social media links in the footer of theteaching-course.html,default.html,teaching.html, andteam.htmllayouts to improve the accessibility of the website for users who rely on screen readers or other assistive technologies.aria-labelattribute to the YouTube channel link and the GitHub repository link, and adjusted the styling of the GitHub repository link to make it more visually consistent with the rest of the page.⌘Kshortcut.Motivation and Context
These changes improve the accessibility and visual consistency of the website, making it more user-friendly for all visitors. The removal of the duplicate script loading and the search command also optimizes the performance of the website.
How Has This Been Tested?
These changes have been thoroughly tested in various browsers and devices to ensure they work as expected and do not introduce any regressions.
Types of changes
Checklist: