-
Notifications
You must be signed in to change notification settings - Fork 0
vs-branch-10 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
vs-branch-10 #39
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
76b04a8
🔖 feat: Add new research paper on viscoelastic Worthington jets and d…
VatsalSy 5069f5e
🎨 feat: Add new history page with news updates
VatsalSy ff95f1d
🎨 feat(history): improve styling and layout of history page
VatsalSy 29b348b
🎨 feat(history): add new history news box styles
VatsalSy 7f3ae17
🔧 refactor: Remove unused `history` collection from config
VatsalSy 89110b9
✨ feat: Add history button to news content
VatsalSy cfeb653
✨ feat: Introduce coding style guidelines across the project
VatsalSy 1c6d38d
✨ refactor: Remove unused .gitignore entry and add newline
VatsalSy 2c3d2f0
🎨 feat: Improve news image styles across the site
VatsalSy d74089f
✨ feat(history): Enhance news item layout and styling
VatsalSy 7bf308a
🎨 refactor(history): improve layout and styling of news sections
VatsalSy fc8d744
✨ feat(history): Enhance history page styles and add CSS variables
VatsalSy f3861fe
🎨 feat(team): Enhance team member content styling and layout
VatsalSy b91c01f
🎨 style(history, news): Improve link styles and add consistent classes
VatsalSy f6e71c8
✨ feat(history): add dark mode styles for links
VatsalSy 0b20e7b
✨ feat(history): add dark mode styling for strong tags
VatsalSy ed9835d
🎨 feat(news): add shared styles for news and history sections
VatsalSy 08e818c
🎨 Refactor: Remove unused course sorting functionality from history page
VatsalSy 326a1e9
✨ feat: Add History button after news items if content exists
VatsalSy 70c06a9
color revamp
VatsalSy 5118ffd
✨ feat(featured): improve featured section styling
VatsalSy 6033a28
✨ feat(styles): Improve CSS organization and theming
VatsalSy b48b6b4
✨ feat(team): Responsive layout and design improvements
VatsalSy 965f799
✨ feat(about): update news header styles and add theme-aware colors
VatsalSy 3705081
🎨 feat(css): Refine news section styles
VatsalSy 967b8a0
✨ feat(styles): enhance featured paper styles
VatsalSy c89363a
✨ feat(teaching): Enhance heading styles and colors
VatsalSy fb93465
✨ feat(shared-news-history): Refine styles and add history-specific s…
VatsalSy 2a00428
✨ feat(team): Enhance team page layout and styling
VatsalSy d9c2e02
🎨 feat(team): Enhance map heading styles
VatsalSy e9425d8
✨ feat(team): enhance team section styles
VatsalSy 576b534
🎨 feat(team): center map description and increase icon size
VatsalSy a8712c5
✨ feat(featured): improve error message for featured papers
VatsalSy ccc8c9c
🎨 feat(team-page): add styling for thesis PDF links
VatsalSy b2f7e7e
✨ feat(team): Optimize team member card layout and content
VatsalSy b215c28
🔖 feat(team): Update team member details
VatsalSy a666a62
✨ feat(team): Improve team section layout and styling
VatsalSy b912626
🎨 feat(team): add PDF link icon styling and update PDF links
VatsalSy a6d782e
✨feat: Add keyboard accessibility to news archive button
VatsalSy 7820250
✨🔒 feat(security): Sanitize Markdown content with DOMPurify
VatsalSy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,5 +31,4 @@ scripts/blog_content.json | |
| .Spotlight-V100 | ||
| .Trashes | ||
| ehthumbs.db | ||
| Thumbs.db | ||
| CLAUDE.md | ||
| Thumbs.db | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --- | ||
| trigger: model_decision | ||
| description: whenever any *.css file is changed | ||
| globs: | ||
| --- | ||
| ## Introduction | ||
|
|
||
| These guidelines establish consistent CSS coding practices, ensuring maintainable and responsive styles across the website. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### CSS Variables | ||
| - Define colors and typography in `:root` | ||
| ```css | ||
| :root { | ||
| --primary-color: #007bff; | ||
| --font-family-base: 'Arial', sans-serif; | ||
| --spacing-unit: 1rem; | ||
| } | ||
| ``` | ||
|
|
||
| ### Responsive Design | ||
| - Use mobile-first approach for media queries | ||
| - Implement breakpoints at: | ||
| - 500px (mobile) | ||
| - 768px (tablet portrait) | ||
| - 900px (tablet landscape) | ||
| - 1300px (desktop) | ||
| - 1700px (large desktop) | ||
|
|
||
| ### Units and Measurements | ||
| - Use `rem` units for font sizes and spacing | ||
| - Use relative units for flexible layouts | ||
| - Use percentages for fluid widths | ||
|
|
||
| ### Example Media Query Structure | ||
| ```css | ||
| /* Mobile first base styles */ | ||
| .component { | ||
| width: 100%; | ||
| } | ||
|
|
||
| /* Tablet portrait */ | ||
| @media (min-width: 768px) { | ||
| .component { | ||
| width: 50%; | ||
| } | ||
| } | ||
|
|
||
| /* Desktop */ | ||
| @media (min-width: 1300px) { | ||
| .component { | ||
| width: 33.33%; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## Common Pitfalls | ||
| - Using pixel units instead of relative units | ||
| - Not following mobile-first approach | ||
| - Hardcoding colors and typography instead of using CSS variables | ||
| - Inconsistent breakpoint usage | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| --- | ||
| trigger: always_on | ||
| description: | ||
| globs: | ||
| --- | ||
| ## Introduction | ||
|
|
||
| These guidelines establish fundamental coding standards that apply across all file types in the project, ensuring consistency and maintainability. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### Indentation and Formatting | ||
| - Use 2-space indentation consistently across all files | ||
| - Maintain consistent spacing around operators and blocks | ||
| - Follow language-specific formatting conventions | ||
|
|
||
| ### Code Organization | ||
| - Follow DRY (Don't Repeat Yourself) principles | ||
| - Reuse components, variables, and styles where possible | ||
| - Keep related code grouped together logically | ||
|
|
||
| ### Documentation | ||
| - Add comments for complex logic | ||
| - Write self-documenting code where possible | ||
| - Use clear, descriptive names for variables, functions, and components | ||
|
|
||
| ## Examples | ||
|
|
||
| ```javascript | ||
| // Good - Self-documenting code with clear naming | ||
| const calculateTotalPrice = (basePrice, taxRate) => { | ||
| return basePrice * (1 + taxRate); | ||
| }; | ||
|
|
||
| // Bad - Unclear naming and unnecessary comments | ||
| const calc = (p, t) => { | ||
| // multiply price by tax | ||
| return p * (1 + t); | ||
| }; | ||
| ``` | ||
|
|
||
| ## Common Pitfalls | ||
| - Inconsistent indentation across different file types | ||
| - Code duplication instead of component reuse | ||
| - Over-commenting obvious code while under-documenting complex logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| --- | ||
| trigger: always_on | ||
| description: | ||
| globs: | ||
| --- | ||
| ## Introduction | ||
VatsalSy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| These guidelines ensure consistent and semantic markup across HTML templates and Markdown content files, promoting accessibility and maintainability. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### HTML Structure | ||
| - Use semantic HTML elements appropriately | ||
| - `<header>` for page headers | ||
| - `<nav>` for navigation | ||
| - `<main>` for primary content | ||
| - `<article>` for self-contained content | ||
| - `<section>` for thematic grouping | ||
| - `<footer>` for page footers | ||
|
|
||
| ### CSS Class Naming | ||
| - Follow BEM (Block Element Modifier) naming convention | ||
| ```html | ||
| <!-- Example of BEM naming --> | ||
| <nav class="s-header__nav"> | ||
| <ul class="s-header__nav-list"> | ||
| <li class="s-header__nav-item"> | ||
| <a class="s-header__nav-link s-header__nav-link--active" href="#">Home</a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| ``` | ||
|
|
||
| ### Markdown Usage | ||
| - Keep content files in Markdown format where possible | ||
| - Use appropriate heading levels (h1-h6) | ||
| - Maintain consistent spacing between sections | ||
| - Use lists and tables for structured content | ||
|
|
||
| ## Common Pitfalls | ||
| - Using non-semantic div elements instead of appropriate HTML5 elements | ||
| - Inconsistent BEM naming patterns | ||
| - Converting Markdown content to HTML unnecessarily | ||
| - Skipping heading levels in document structure | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| --- | ||
| trigger: model_decision | ||
| description: working with images | ||
| globs: | ||
| --- | ||
VatsalSy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ## Introduction | ||
|
|
||
| These guidelines ensure consistent image handling, optimization, and accessibility across the website. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### Image Optimization | ||
| - Compress all images to reduce file size while maintaining acceptable quality | ||
| - Choose appropriate image formats: | ||
| - JPEG for photographs | ||
| - PNG for images with transparency | ||
| - SVG for icons and logos | ||
| - WebP as a modern alternative when browser support allows | ||
|
|
||
| ### Naming Convention | ||
| - Follow the pattern: `[name]-[descriptor].[extension]` | ||
| - Examples: | ||
| ``` | ||
| profile-photo.jpg | ||
| hero-banner-large.png | ||
| icon-search.svg | ||
| ``` | ||
|
|
||
| ### Accessibility | ||
| - Include meaningful alt text for all images | ||
| - Use empty alt="" for decorative images | ||
| - Provide descriptive filenames that indicate image content | ||
|
|
||
| ### Example Implementation | ||
| ```html | ||
| <!-- Good --> | ||
| <img | ||
| src="team-member-john.jpg" | ||
| alt="Dr. John Smith, Lead Researcher" | ||
| width="300" | ||
| height="400" | ||
| /> | ||
|
|
||
| <!-- Bad --> | ||
| <img src="IMG001.jpg" /> | ||
| ``` | ||
|
|
||
| ## Common Pitfalls | ||
| - Uploading uncompressed images | ||
| - Missing alt text on important images | ||
| - Using generic or numbered filenames | ||
| - Not following the naming convention | ||
| - Forgetting to specify image dimensions | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| trigger: model_decision | ||
| description: making js related edits | ||
| globs: | ||
| --- | ||
VatsalSy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ## Introduction | ||
|
|
||
| These guidelines establish modern JavaScript coding practices, ensuring consistent and maintainable code across the project. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### Modern JavaScript Features | ||
| - Use ES6+ features consistently: | ||
| - Arrow functions for callbacks and methods | ||
| - Template literals for string interpolation | ||
| - Destructuring for object and array manipulation | ||
| - Spread/rest operators where appropriate | ||
|
|
||
| ### Code Structure | ||
| - Always include 'use strict' mode | ||
| - Use `const` by default, `let` when reassignment is needed | ||
| - Never use `var` | ||
| - Use camelCase for variable and function names | ||
|
|
||
| ### Asynchronous Code | ||
| - Use async/await for asynchronous operations | ||
| - Implement proper error handling with try/catch blocks | ||
| ```javascript | ||
| // Good | ||
| async function fetchData() { | ||
| try { | ||
| const response = await api.getData(); | ||
| return response; | ||
| } catch (error) { | ||
| console.error('Error fetching data:', error); | ||
| throw error; | ||
| } | ||
| } | ||
|
|
||
| // Bad | ||
| function fetchData() { | ||
| return api.getData() | ||
| .then(response => response) | ||
| .catch(error => console.error(error)); | ||
| } | ||
| ``` | ||
|
|
||
| ### Event Handling | ||
| - Prefer event delegation for multiple similar elements | ||
| - Use descriptive event handler names | ||
| - Remove event listeners when components are destroyed | ||
|
|
||
| ## Common Pitfalls | ||
| - Not using strict mode | ||
| - Mixing async/await with .then() chains | ||
| - Missing error handling in async operations | ||
| - Using var instead of const/let | ||
| - Direct event binding instead of delegation for multiple elements | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| trigger: always_on | ||
| description: | ||
| globs: | ||
| --- | ||
VatsalSy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ## Introduction | ||
|
|
||
| These guidelines ensure consistent project organization and documentation maintenance across the CoMPhy Lab website codebase. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| ### Repository Structure | ||
| - The README.md file at repository root serves as the primary documentation | ||
| - Templates are located in `_layouts/*.html` | ||
| - Each template has a corresponding CSS file: | ||
| - `default.html` → `assets/css/styles.css` | ||
| - `research.html` → `assets/css/research.css` | ||
| - `team.html` → `assets/css/team.css` | ||
| - All templates use `search.css` and `styles.css` | ||
|
|
||
| ### Documentation Maintenance | ||
| - Keep README.md up-to-date with any structural changes | ||
| - Document any new files or directories added to the project | ||
| - Manual control over Jekyll server deployment is preferred | ||
|
|
||
| ## Common Pitfalls | ||
| - Forgetting to update README.md after structural changes | ||
| - Inconsistent template-to-CSS file mapping | ||
| - Running Jekyll server automatically instead of manual control | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.