Android support #53

mzdk100 · 2025-07-20T07:38:28Z

This is an initial commit that only implements the Runtime on Android.

# Conflicts: # winio/examples/fs.rs

Berrysoft · 2025-07-20T13:38:24Z

winio-ui-android/src/runtime.rs

+        RUNTIME.set(self, f)
+    }
+
+    pub fn block_on<F: Future>(&self, future: F) -> F::Output {


Please refer to winio-pollable and winio-ui-winui for a correct implementation of block_on.

We don't alloc for future. We just call spawn_unchecked.

We need to poll the driver fd and the app event together. If it's not possible, we poll the driver fd in another thread. Your current implementation is enough for GUI to run correctly, but the IO operations will not complete.

Berrysoft

Please rebase the PR.
Please add .idea to .gitignore.

I have left some comments. The runtime needs to be modified to make sure compio works well.

Berrysoft · 2025-07-20T13:40:44Z

mobile-examples/android/run.bat

Just a suggestion: maybe better to use Makefile?

winio-ui-android/Cargo.toml

Berrysoft · 2025-07-20T13:42:11Z

winio-ui-android/src/ui/label.rs

+        // 通过JNI设置TextView的文本对齐方式
+        RUNTIME.with(|rt| {
+            let view = self.tv.clone();
+            rt.vm_exec(|mut env, _act| {


Just comment: seems too painful to implement.

Berrysoft · 2025-07-20T13:42:53Z

winio/Cargo.toml

@@ -31,7 +31,10 @@ winio-ui-winui = { workspace = true, optional = true }
 [target.'cfg(target_os = "macos")'.dependencies]
 winio-ui-app-kit = { workspace = true }

-[target.'cfg(not(any(windows, target_os = "macos")))'.dependencies]
+[target.'cfg(target_os="android")'.dependencies]
+winio-ui-android = { workspace = true, optional = true }


It doesn't have to be an optional dependency.

mzdk100 · 2025-07-20T13:45:14Z

Okay, I need some time to study.

Co-authored-by: Yuyi Wang <[email protected]>

Berrysoft · 2025-07-20T13:50:01Z

Take it easy. You have done tremendous work. It's just some small problems (and a lot of todo!()s).

Does the java vm have to be executed every time in each method? Could we just execute the vm in block_on?

mzdk100 · 2025-07-20T14:09:42Z

Does the java vm have to be executed every time in each method? Could we just execute the vm in block_on?

It can run in block_on. However, I found that when calling some Android APIs, they are very strict with thread checking (android_activity::AndroidApp creates a separate sub thread when the application starts, and android_main runs in this separate thread, requiring us to complete UI update operations in this sub thread). In our own block_on method, it seems that it is not this thread (for example, calling the WindowManager.addView method will fail):
E AndroidRuntime: FATAL EXCEPTION: Thread-5
E AndroidRuntime: Process: rust.winio_android_example, PID: 1947
E AndroidRuntime: java.lang.RuntimeException: Can't create handler inside thread Thread[Thread-5,10,main] that has not called Looper.prepare()
E AndroidRuntime: at android.os.Handler.(Handler.java:228)
E AndroidRuntime: at android.os.Handler.(Handler.java:130)
E AndroidRuntime: at android.view.ViewRootImpl$ViewRootHandler.(ViewRootImpl.java:7577)
E AndroidRuntime: at android.view.ViewRootImpl.(ViewRootImpl.java:7995)
E AndroidRuntime: at android.view.ViewRootImpl.(ViewRootImpl.java:1504)
E AndroidRuntime: at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:534)
E AndroidRuntime: at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:426)
E AndroidRuntime: at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:178)
If running in android_main, this situation is impossible (because Looper will be automatically created), so I don't know if the block_on method will be scheduled by Winio to run on another thread.

Berrysoft · 2025-07-20T14:29:43Z

I understand about the thread checking. But anyway the future is running on the same thread as block_on. If it's valid to call vm_exec inside the future, it should be valid to call vm_exec inside block_on.

mzdk100 · 2025-07-20T14:36:50Z

If it's valid to call vm_exec inside the future, it should be valid to call vm_exec inside block_on
That's right, the future and block_on belong to the same thread. But now this thread is not the expected thread for android_activity::AndroidApp.

Berrysoft · 2025-07-20T14:38:21Z

If it's not the correct thread, how do you call vm_exec in the correct thread?

mzdk100 · 2025-07-20T14:45:11Z

I should have investigated thoroughly, it's not a block_on issue.

…ock usage

# Conflicts: # Cargo.toml # winio-elm/src/lib.rs # winio-handle/src/lib.rs

Berrysoft

Please remove the changes not relative to Android support.

Berrysoft · 2025-07-21T07:06:31Z

Cargo.toml

@@ -20,7 +20,7 @@ members = [
 resolver = "2"

 [workspace.package]
-edition = "2021"
+edition = "2024"


Better not. It's not recommended to use edition = 2024 in libs, because it limits the supported rustc version.

It's okay, edition2024 will be compatible with older versions of Rustc, and many of the new features it brings are very practical.

Please explain with more details that why do you need edition 2024.

…e method definitions

…ctionality

…ove Edit text handling

# Conflicts: # winio-ui-win32/src/ui/edit.rs

…ld requirements

…eanup TODOs

…nctionality refactor(android): cleanup TODOs and implement missing Progress methods feat(examples): add widgets example for Android and update hello example fix(layout): fix macro syntax for expr patterns Signed-off-by: SmileSky <[email protected]>

…onality refactor(android): cleanup TODOs and implement missing methods for widgets feat(android): add event handling for ComboBox change and select events refactor(android): improve widget conversion and add Option<usize> support Signed-off-by: SmileSky <[email protected]>

…Edit widgets refactor(android): rename ComboBox event methods to past tense (on_change -> on_changed) feat(android): add Tooltip implementation with accessibility support fix(android): implement missing Progress and RadioButton widget methods feat(android): add text change events for Edit and TextBox widgets Signed-off-by: SmileSky <[email protected]>

…s, pens, paths, and images Signed-off-by: SmileSky <[email protected]>

SmileSky added 4 commits July 15, 2025 15:59

fix(winio): use BufResult pattern for read_to_end_at in fs example

b6073e7

Merge remote-tracking branch 'origin/master'

f233a5f

# Conflicts: # winio/examples/fs.rs

Merge remote-tracking branch 'origin/master'

159e7f5

feat(android): add initial Android UI widgets and runtime support

bdec7e7

Berrysoft reviewed Jul 20, 2025

View reviewed changes

Berrysoft requested changes Jul 20, 2025

View reviewed changes

Update winio-ui-android/Cargo.toml

6d9a15c

Co-authored-by: Yuyi Wang <[email protected]>

SmileSky added 3 commits July 21, 2025 09:30

fix(android): update code for Rust 2024 edition and improve unsafe bl…

9f67f73

…ock usage

Merge remote-tracking branch 'origin/master'

db083fd

Merge branch 'refs/heads/master' into android

dee58f6

# Conflicts: # Cargo.toml # winio-elm/src/lib.rs # winio-handle/src/lib.rs

Berrysoft reviewed Jul 21, 2025

View reviewed changes

SmileSky added 12 commits July 21, 2025 16:13

feat(android): implement Android UI widgets and enhance widget structure

619f978

feat(android): add Activity class and JNI integration for native methods

e1cad27

feat(android): enhance widget functionality and add new UI components

2b570ec

Merge remote-tracking branch 'origin/master'

feb6141

Merge branch 'master' into android

009aa51

feat(android): refactor widget structure to use BaseWidget and improv…

e196874

…e method definitions

feat(android): implement visibility and size methods for UI components

8db2036

feat(android): add Button, CheckBox, and Edit classes with widget fun…

71e5735

…ctionality

feat(android): add event handling for Button and Window widgets

b2ab295

feat(android): remove mutable references from widget methods and impr…

2bac90b

…ove Edit text handling

Merge remote-tracking branch 'origin/master'

587f6f2

Merge branch 'master' into android

6369791

# Conflicts: # winio-ui-win32/src/ui/edit.rs

SmileSky added 6 commits July 26, 2025 13:21

refactor(examples): remove winio hello example and update android bui…

24e3ebc

…ld requirements

feat(android): implement enabled state methods for all widgets and cl…

782cbd6

…eanup TODOs

feat(android): implement comprehensive Canvas drawing API with brushe…

2f60055

…s, pens, paths, and images Signed-off-by: SmileSky <[email protected]>

Android support #53

Are you sure you want to change the base?

Android support #53

Uh oh!

Conversation

mzdk100 commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Berrysoft Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Berrysoft left a comment

Choose a reason for hiding this comment

Uh oh!

Berrysoft Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Berrysoft Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Berrysoft Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

mzdk100 commented Jul 20, 2025

Uh oh!

Berrysoft commented Jul 20, 2025

Uh oh!

mzdk100 commented Jul 20, 2025

Uh oh!

Berrysoft commented Jul 20, 2025

Uh oh!

mzdk100 commented Jul 20, 2025

Uh oh!

Berrysoft commented Jul 20, 2025

Uh oh!

mzdk100 commented Jul 20, 2025

Uh oh!

Berrysoft left a comment

Choose a reason for hiding this comment

Uh oh!

Berrysoft Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

mzdk100 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Berrysoft Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzdk100 commented Jul 20, 2025 •

edited

Loading