Skip to content

Conversation

balazsmatepetro
Copy link
Contributor

This PR adds the missing type definition files for FocusWithin component.

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2020

🦋 Changeset is good to go

Latest commit: 161bbe7

We got this.

This PR includes changesets to release 1 package
Name Type
@component-driven/react-focus-within Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okonet
Copy link
Member

okonet commented Jun 5, 2020

@balazsmatepetro did you figure out the bundling problem?

@balazsmatepetro
Copy link
Contributor Author

@balazsmatepetro did you figure out the bundling problem?

I had a look at on it, as I've seen the type definitions are included in the bundle, but it might worth converting the whole component into TypeScript.

@okonet
Copy link
Member

okonet commented Jun 24, 2020

I think it's worth converting it to TS. Want to give it a try?

@balazsmatepetro
Copy link
Contributor Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants