Skip to content

Conversation

jasonkuhrt
Copy link
Member

...te linking work.

This only really matters because the package name is not the same as the repo name which makes inferring the github URI not obvious.

…bsite linking work.

This only really matters because the package name is not the same as the repo name which makes inferring the github URI not obvious.
@jasonkuhrt
Copy link
Member Author

Actually the package naming is ok since the component prefix corresponds to the github org name. I suppose the issue thereafter is that /build.js is used instead of just /build.

Seems like sticking with /build and dropping .js would be better. If additional languages get supported they can be forced to add the suffix. /build.h etc.

@jonathanong
Copy link
Contributor

i think this is an npm bug. i saw a PR to fix this in npm but i don't know if it's merged yet

@jasonkuhrt
Copy link
Member Author

@jonathanong Agreed its an npm bug (that just logically makes sense). I hesitated making this PR for that reason but then decided fixing the link now saves us from making guesses about the actual github URI for reasons stated above. Again I'm not sure if using /build.js is the best approach for component repos since that's not what we require(...) and is not obviously a suffix system (vs component-* being a reasonably obvious prefix that maps to a github org name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants