Skip to content

remove the background grid #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

remove the background grid #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2882ba4
fix: remove the background
jetpham Oct 22, 2024
85baff6
feat: add yellow borders over sections and remove stupid little list …
jetpham Oct 22, 2024
014399f
fix: apply to resources
jetpham Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion platform/app/Home.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ section.details {
margin-bottom: 80px;
}

section.innerSections {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new class name creates more boilerplate than necessary; can be replaced with section.details > section

border: 2px solid var(--color-compsigh);
padding: 20px;
border-radius: 10px;
}

.block code {
display: block;
font-family: var(--font-proto-mono);
Expand Down Expand Up @@ -64,4 +70,4 @@ pre.block-mobile {
pre.block-mobile {
display: block;
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

11 changes: 0 additions & 11 deletions platform/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

body {
overflow-x: hidden;
background-image: url('/gridrect.svg');
background-repeat: repeat;
background-color: var(--color-dark);
color: var(--color-light);
Expand Down Expand Up @@ -87,12 +86,6 @@ ul > li {
list-style-type: none;
}

ul > li::before {
position: absolute;
margin-left: -22px;
content: '>';
}

Comment on lines -90 to -95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, removing list styles is an accessibility--, not ++

ul ul {
margin: unset;
}
Expand All @@ -104,10 +97,6 @@ ol ol > li {
margin-left: 1em;
}

li.back::before {
content: '<';
}

select {
font-family: var(--font-proto-mono);
font-size: 1rem;
Expand Down
16 changes: 8 additions & 8 deletions platform/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default async function Home() {
</header>

<section className={styles.details}>
<section>
<section className={styles.innerSections}>
<h2>Eligibility</h2>
<p>DEPLOY/24 is geared towards CS and our friends from other creative areas of study like design, engineering, and E&I, but all USF students are welcome and encouraged to participate!</p>
<p>Anyone is welcome to come hang out and hack, but <strong>only USF students who register for the event will be eligible to win</strong>.</p>
Expand Down Expand Up @@ -77,7 +77,7 @@ export default async function Home() {
</table>
</section>

<section>
<section className={styles.innerSections}>
<h2>Submissions</h2>
<p>Only one team member has to submit the project on behalf of the team.</p>
<p>Project submissions are not limited to a theme — build whatever you like! Common project formats:</p>
Expand All @@ -96,7 +96,7 @@ export default async function Home() {
<p>Submissions don&apos;t have to be complete! <em>What worked? What didn&apos;t? How would you continue to develop the project?</em></p>
</section>

<section>
<section className={styles.innerSections}>
<h2>Presentations</h2>
<ul>
<li>Your team presents: 5 minutes</li>
Expand All @@ -112,7 +112,7 @@ export default async function Home() {
<p>In your presentation, please make sure your team members&apos; roles in bringing the project to life are clearly articulated.</p>
</section>

<section>
<section className={styles.innerSections}>
<h2>How to win</h2>
<p>Teams can earn a People&apos;s Choice, 3rd, 2nd, or 1st Place victory.</p>
<p>An array (lol) of professors — primarily from computer science — will be joining us on Sunday to judge presentations.</p>
Expand Down Expand Up @@ -159,12 +159,12 @@ export default async function Home() {
</ul>
</section>

<section>
<section className={styles.innerSections}>
<h2>Prizes</h2>
<p>TBA :)</p>
</section>

<section>
<section className={styles.innerSections}>
<h2>Agenda</h2>
<p>Friday, November 08</p>
<table>
Expand Down Expand Up @@ -235,7 +235,7 @@ export default async function Home() {
</table>
</section>

<section>
<section className={styles.innerSections}>
<h2>Breakout Spaces</h2>
<p>These rooms will be available throughout the weekend for teams to work in:</p>
<ul>
Expand All @@ -247,7 +247,7 @@ export default async function Home() {
</ul>
</section>

<section className={styles.resources}>
<section className={styles.innerSections}>
<h2>Resources</h2>
<p>Whether it&apos;s your first-ever hackathon, or you&apos;re a seasoned hacker, we hope you&apos;ll enjoy the event! To get the most out of the experience, here are some pieces of advice compsigh members have contributed:</p>
<blockquote>
Expand Down