Add explanation of statistics system Comunica #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensworks
requested changes
Feb 10, 2025
| const QueryEngine = require('@comunica/query-sparql').QueryEngine; | ||
| const engine = new QueryEngine(); | ||
|
|
||
| const query: string = " .... " |
There was a problem hiding this comment.
It would be useful if we had a complete working example here.
|
|
||
| ```typescript | ||
| statistic.on((data) => { | ||
| // Do something here |
There was a problem hiding this comment.
Could you give an example of what could be done with this data?
To clarify what data is.
| As the query executes, Comunica **emits these metrics in real time**, enabling other (future) Comunica actors to adaptively optimize query processing. | ||
| After query completion, these statistics can be analyzed to gain insights into execution behavior and performance characteristics. | ||
|
|
||
| ## Link Discovery and Dereference Events |
There was a problem hiding this comment.
Maybe we can precede this title by saying something like "The available types of statistics are described in more detail below".
| ``` | ||
| The `wraps` field on the `ActorIteratorTransformRecordIntermediateResults` indicates which query operations or joins will be wrapped. | ||
| In the example, intermediate results for inner, minus, and optional joins will be recorded, in addition to the final project result. | ||
| These intermediate results are produced and emitted by `StatisticIntermediateResults`, which should be included in the context in the same manner as `StatisticLinkDiscovery` and `StatisticLinkDereference`. |
There was a problem hiding this comment.
Maybe we can give a brief example of this as well?
|
Maybe we can also move this one to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.