-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencolorio: Bump lcms requirement to 2.16 #25660
opencolorio: Bump lcms requirement to 2.16 #25660
Conversation
To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support both opencolorio & libjxl requirements at the same time, the lcms version needs to match.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with @irieger, we have decided that: We're bumping this to 2.16, followed by the potentially-conflicting libraw, once openimageio gets its dependency also bumped as part of its 3rd major release, and once the new pipeline is in-place we will look into making lcms a version-rangeable dependency, thanks!
This PR has been automatically merged due to |
To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support both opencolorio & libjxl requirements at the same time, the lcms version needs to match.
* Revert "(conan-io#25660) opencolorio: Bump lcms requirement to 2.16" This reverts commit cd1cf21. * Fix linter warning
Summary
Changes to recipe: opencolorio/all
Motivation
To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support both opencolorio & libjxl requirements at the same time, the lcms version needs to match.
(I have a branch for OpenImageIO 3.0.0.0 which currently uses the beta but will be published as an MR once the release has happened. #25672 is created to start discussion and try if everything else builds in all CI combinations already)
Details
OpenImageIO with the addition of libjxl currently results in a graph error due to libjxl requireing lcms/2.16 while opencolorio requires lcms/2.14
The only user of OpenColorIO in CCI is OpenImageIO so the side effect should hopefully be small.