Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencolorio: Bump lcms requirement to 2.16 #25660

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Oct 18, 2024

Summary

Changes to recipe: opencolorio/all

Motivation

To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support both opencolorio & libjxl requirements at the same time, the lcms version needs to match.

(I have a branch for OpenImageIO 3.0.0.0 which currently uses the beta but will be published as an MR once the release has happened. #25672 is created to start discussion and try if everything else builds in all CI combinations already)

Details

OpenImageIO with the addition of libjxl currently results in a graph error due to libjxl requireing lcms/2.16 while opencolorio requires lcms/2.14

The only user of OpenColorIO in CCI is OpenImageIO so the side effect should hopefully be small.


To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support
both opencolorio & libjxl requirements at the same time, the lcms version needs to match.
@conan-center-bot

This comment has been minimized.

irieger added a commit to irieger/conan-center-index that referenced this pull request Oct 19, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Oct 21, 2024
@conan-center-bot conan-center-bot added Bump dependencies Only bumping dependencies versions in the recipe and removed Waiting for CI labels Oct 21, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (d2417ee5cb34acf79e1c44caa5ac6a0d3e0c7ffc):

  • opencolorio/2.3.1:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.4.0:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.3.2:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.2.1:
    Built 18 packages out of 22 (All logs)

  • opencolorio/1.1.1:
    All packages built successfully! (All logs)

  • opencolorio/2.3.0:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (d2417ee5cb34acf79e1c44caa5ac6a0d3e0c7ffc):

  • opencolorio/2.3.2:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.3.1:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.2.1:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.4.0:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.3.0:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)

  • opencolorio/1.1.1:
    Built 3 packages out of 10 (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @irieger, we have decided that: We're bumping this to 2.16, followed by the potentially-conflicting libraw, once openimageio gets its dependency also bumped as part of its 3rd major release, and once the new pipeline is in-place we will look into making lcms a version-rangeable dependency, thanks!

@conan-center-bot conan-center-bot merged commit cd1cf21 into conan-io:master Nov 2, 2024
33 checks passed
@conan-center-bot
Copy link
Collaborator

This PR has been automatically merged due to Bump version or Bump dependencies label.
Read https://github.com/conan-io/conan-center-index/blob/master/docs/labels.md#bump-version to obtain more information.

AbrilRBS added a commit that referenced this pull request Nov 2, 2024
@irieger irieger deleted the opencolorio/bump-lcms branch November 2, 2024 11:03
@irieger irieger restored the opencolorio/bump-lcms branch November 2, 2024 11:03
@irieger irieger deleted the opencolorio/bump-lcms branch November 2, 2024 11:03
jcar87 pushed a commit that referenced this pull request Nov 2, 2024
* Revert "(#25660) opencolorio: Bump lcms requirement to 2.16"

This reverts commit cd1cf21.

* Fix linter warning
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
To prepare OpenImageIO 3.0.0.0 which is currently in beta and added libjxl support, to support
both opencolorio & libjxl requirements at the same time, the lcms version needs to match.
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* Revert "(conan-io#25660) opencolorio: Bump lcms requirement to 2.16"

This reverts commit cd1cf21.

* Fix linter warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump dependencies Only bumping dependencies versions in the recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants