Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libkml: fall back to C++14 #23755

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Apr 25, 2024

This library uses features of C++ that are removed in C++17, and is currently failing building with MSVC with C++17 or higher.

in this PR: add fallback to compile with C++14 when anything higher than 14 is requested.

the compatibility.py extension in Conan 2 will fallback to the binary with C++14 on the consumer side.

In addition to the configurations tested by CI, this was locally tested on Windows with msvc with C++17.

@ghost
Copy link

ghost commented Apr 25, 2024

I detected other pull requests that are modifying libkml/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 self-assigned this Apr 25, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (de43deefd8fd93087595f02538a42e3ea9e4e3c5):

  • libkml/1.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (de43deefd8fd93087595f02538a42e3ea9e4e3c5):

  • libkml/1.3.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0706d5d into conan-io:master Apr 25, 2024
11 of 12 checks passed
@jcar87 jcar87 deleted the lcc/libkml-cpp-fallback branch April 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants