Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libe57format] Fix compilation with gcc-13 #26481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artem-ogre
Copy link
Contributor

See: https://gcc.gnu.org/gcc-13/porting_to.html

Summary

Changes to recipe: libe57format/[2.3.0]

Motivation

Does not compile with gcc-13

Details

See: https://gcc.gnu.org/gcc-13/porting_to.html
<cstdint> now needs to be included directly.

@artem-ogre artem-ogre force-pushed the libe57format-gcc13 branch 2 times, most recently from 8340228 to 5a098e2 Compare January 30, 2025 11:55
@artem-ogre
Copy link
Contributor Author

Rebased on top of master.

@jcar87
Copy link
Contributor

jcar87 commented Jan 30, 2025

Rebased on top of master.

Thanks @artem-ogre - bear in mind that rebasing on top of master is only necessary when the recipe has been updated in master - if that is not the case, it tends to be a little counter productive, as it causes CI to be relaunched. If a PR is merged to master that modifies a recipe, all other PRs that touch the same recipe are "invalidated" - it's only in those cases that rebasing is necessary so that the new recipe revision can be computed by CI.

@artem-ogre
Copy link
Contributor Author

@jcar87
The recipe was updated on master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants