Add patch to fix C++20 support when building doxygen #26485
Conversation
|
Hi @Twon - thanks for this PR. Please check the recipe locally with this patch, as it appears it doesnt apply cleanly and fails CI |
Sorry about that, let me look into that. |
|
Building locally with the following profile:
conan create ./conanfile.py --name doxygen --version 1.12.0 --build=missing -pr:a ./profile.txt
======== Exporting recipe to the cache ======== ======== Input profiles ======== Profile build: ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== -------- Installing package doxygen/1.12.0 (10 of 10) -------- doxygen/1.12.0: Running CMake.build() doxygen/1.12.0: Package '0566774e37e2c4081f1056f5f92d2312eb7a1053' built doxygen/1.12.0: package(): Packaged 4 files: doxyindexer, doxyparse, doxygen, LICENSE ======== Launching test_package ======== ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== ======== Testing the package ======== ======== Testing the package: Building ======== ======== Testing the package: Executing test ======== |
There was a problem hiding this comment.
Hi @Twon - thanks for this PR.
For traceability purposes - the patch source that you have linked (doxygen/doxygen@54259f7) - does not match contents of the patch you are adding in this PR.
As per out patching policy, we consider this types of patches if they already originate in the upstream repo or have a well trusted source https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#policy-on-patches
Perhaps the patch needs to be amended to cover only the contents of the referenced patch? Thanks!
|
@jcar87 yes, you're completely right. The other changes are related to different stuff for instance: |
|
After the initial patch did not apply cleanly, the second attempt was of the desired commit against the 1.12.0 release head. Given this pull in undesirable changes I'm inclined to close this and accept this version of the Doxygen package should never build under C++20. Even if the initial patch could be modified so as to keep it to the minimal change but they actually applied cleanly, because the 1.12.0 release of Doxygen also did not build under C++20. I suspect the correct course of action is for users to pin this package to build under C++17 (i.e. |
Summary
Changes to recipe: doxygen/1.12.0
Motivation
The doxygen/1.120 package does not compile under C++20. This was fixed in the Doxygen repository in this change: doxygen/doxygen@54259f7
Currently this fails with the following error:
Details
This change introduces a patch that is required to ensure Doxygen builds under C++20