acado/1.2.2-beta relocatable #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
blackliner
force-pushed
the
acado-relocatable
branch
from
c0c0905 to
15d8c59
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
:-( |
madebr
reviewed
May 18, 2021
|
This problem looks similar to the build problems with boost. |
This comment has been minimized.
This comment has been minimized.
|
thanks @madebr , that did the trick 👍 |
madebr
previously approved these changes
May 19, 2021
| ExportFile::setup( _fileName, _commonHeaderName, _realString, _intString, _precision, _commentString ); | ||
|
|
||
| - folders = TEMPLATE_PATHS; | ||
| + if(const char* template_paths = std::getenv("ACADO_TEMPLATE_PATHS")) |
There was a problem hiding this comment.
Are you going to try to upstream this patch?
There was a problem hiding this comment.
the project is dead unfortunately.
There was a problem hiding this comment.
It's the packaging into Conan that breaks the project structure, not really a bug as much as a feature from what I see
uilianries
reviewed
May 19, 2021
Co-authored-by: Uilian Ries <[email protected]>
|
All green in build 5 (
|
prince-chrismc
approved these changes
May 19, 2021
madebr
approved these changes
May 19, 2021
SSE4
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: acado/1.2.2-beta
Making acado relocateable.
Question: Is
self.env_info.ACADO_TEMPLATE_PATHSstill the correct way to have env-values set whenever this library is part of the build-tree? It is important, that all users of this library have this env-var set. I also assume this happens during execution of the generators, likecmake_find_package, and not during build or packaging of this library.conan-center hook activated.