new test for build-scripts transitive #18238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
May 8, 2025
AbrilRBS
approved these changes
May 8, 2025
| @@ -85,6 +86,40 @@ def build(self): | |||
| assert "MYFUNCTION CMAKE A: Hello world A!!!" in c.out | |||
|
|
|||
|
|
|||
| def test_transitive_build_scripts_error(): | |||
There was a problem hiding this comment.
Is this a functional test? Looks like an integration one (maybe add light=True)?
There was a problem hiding this comment.
Yes, this one is more an integration test, but it was developed here because of being very close to the topic of the other tests in this file, while I couldn't find a better location in integration that wouldn't be a new test file just for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Close #18235