package_manager version support added #18517
Conversation
| @@ -25,8 +25,6 @@ def system_requirements(self): | |||
| print("missing:", not_installed) | |||
| """)}) | |||
| client.run("create . --name=test --version=1.0 -s:b arch=armv8 -s:h arch=x86") | |||
| assert "dpkg-query: no packages found matching non-existing1:i386" in client.out | |||
There was a problem hiding this comment.
I've removed these lines because dpkg -l doesn't print anything if it doesn't find any package with the search pattern
| install_command = "{sudo}{tool} install -y {recommends}{packages}" | ||
| update_command = "{sudo}{tool} update" | ||
| check_command = "dpkg-query -W -f='${{Status}}' {package} | grep -q \"ok installed\"" | ||
| check_command = "dpkg -l | grep -q -E \"^ii\\s+\\b{package}\\s+\\b\"" |
There was a problem hiding this comment.
Does the change to check_command solve issues of the previous one, or is this change more to align it with the check_version_command?
There was a problem hiding this comment.
This change is necessary to fix a false positive issue we had before. It is also to align with the way of checking the version of a package.
If your package had a default architecture that was implicit and the others were explicit, the old check found the default package substring within an installation for another architecture:
For example: foo and foo:armv8. The old check said that foo was already installed if it found foo:armv8.
| arch_name=arch_name, | ||
| version="", | ||
| version_separator="") | ||
| if version and self.check_version_command: |
There was a problem hiding this comment.
Maybe we should we output a warning message when we are specifying versions but the package manager does not support that?
Co-authored-by: James <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Changelog: Feature: Added support to the system_package tool for defining the system package version to be installed
Docs: conan-io/docs#4170
Close #17744
developbranch, documenting this one.