Adding new concepts #1504
Adding new concepts #1504
Conversation
|
@AnnikaTjuka, could you moderate this PR? |
|
Sure. @FredericBlum Would you review this PR since you were also involved in some of the discussions? |
|
If next week is sufficient, yes. I have some thesis stress right now. |
|
Sure, no worries. This has no urgency. |
FredericBlum
left a comment
FredericBlum
left a comment
There was a problem hiding this comment.
Looks good! And the test shows no errors. From my side, this can be merged.
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
I left a few comments.
concepticondata/concepticon.tsv
Outdated
| 4124 FILTH The physical world Strongly disgusting or repulsive substances, e.g., sewage or excrement Person/Thing | ||
| 4125 GUILT Emotions and values A negative emotional state arising from the belief or awareness that one has committed a wrong or violated a moral or social standard. Person/Thing No newline at end of file | ||
| 4125 GUILT Emotions and values A negative emotional state arising from the belief or awareness that one has committed a wrong or violated a moral or social standard. Person/Thing | ||
| 4126 BISCUIT Food and drink A small baked food made from flour, typically firm or crisp, and often eaten as a snack or with a meal. Person/Thing |
There was a problem hiding this comment.
I'd change "meal" into "tea" ;)
concepticondata/concepticon.tsv
Outdated
| 4125 GUILT Emotions and values A negative emotional state arising from the belief or awareness that one has committed a wrong or violated a moral or social standard. Person/Thing | ||
| 4126 BISCUIT Food and drink A small baked food made from flour, typically firm or crisp, and often eaten as a snack or with a meal. Person/Thing | ||
| 4127 BLACKBIRD Animals A medium-sized passerine bird of the thrush family, typically characterized by dark, often black plumage. Person/Thing | ||
| 4128 BRA Clothing and grooming garment worn on the upper body, designed to support and cover the breasts. Person/Thing |
There was a problem hiding this comment.
"garment" = "Garment"
There was a problem hiding this comment.
To be more specific, I'd add "female" in front of "breasts".
concepticondata/concepticon.tsv
Outdated
| 4130 CHALK Basic actions and technology A soft white or pale limestone composed mainly of calcium carbonate, commonly used for writing, marking, or drawing on surfaces. Person/Thing | ||
| 4131 CHIPMUNK Animals A small striped rodent of the squirrel family, native to North America, known for storing food in its cheek pouches. Person/Thing | ||
| 4132 COD Animals A large marine fish of the genus Gadus, commonly found in cold ocean waters and widely used as food. Person/Thing | ||
| 4133 DAGGER Warfare and hunting short, pointed weapon with a double-edged blade, designed for stabbing or thrusting, often used in close combat. Person/Thing |
concepticondata/concepticon.tsv
Outdated
| 4132 COD Animals A large marine fish of the genus Gadus, commonly found in cold ocean waters and widely used as food. Person/Thing | ||
| 4133 DAGGER Warfare and hunting short, pointed weapon with a double-edged blade, designed for stabbing or thrusting, often used in close combat. Person/Thing | ||
| 4134 FAWN Animals A young deer, typically in its first year, often characterized by a spotted coat. Person/Thing | ||
| 4135 JAR Basic actions and technology A cylindrical container, usually made of glass or pottery, used for storing food, liquids, or other small items. Person/Thing |
There was a problem hiding this comment.
I'd change the semantic field to "Food and drink".
concepticondata/concepticon.tsv
Outdated
| 4134 FAWN Animals A young deer, typically in its first year, often characterized by a spotted coat. Person/Thing | ||
| 4135 JAR Basic actions and technology A cylindrical container, usually made of glass or pottery, used for storing food, liquids, or other small items. Person/Thing | ||
| 4136 MEDAL Social and political relations A small, flat, typically metal object awarded to commemorate an achievement, honor, or participation in an event, often inscribed or engraved with relevant symbols or text. Person/Thing | ||
| 4137 MUG Basic actions and technology A sturdy cup, typically with a handle, usually made of ceramic or metal used for drinking beverages, mainly hot ones. Person/Thing |
There was a problem hiding this comment.
I'd change the semantic field to "Food and drink".
concepticondata/concepticon.tsv
Outdated
| 4140 RIFLE Warfare and hunting A long-barreled firearm designed to be fired from the shoulder, with a rifled bore that imparts spin to the projectile for increased accuracy. Person/Thing | ||
| 4141 ROBE Clothing and grooming A loose-fitting outer garment, often long and flowing, typically worn for ceremonial, religious, or formal purposes. Person/Thing | ||
| 4142 SQUID Animals A marine cephalopod with a soft elongated body, eight arms, and two longer feeding tentacles, capable of jet propulsion and ink release. Person/Thing | ||
| 4143 THIMBLE Basic actions and technology A small protective cap, typically made of metal, plastic, or leather, worn on the finger to push a needle while sewing. Person/Thing |
There was a problem hiding this comment.
I'd change the semantic field to "Clothing and grooming" (same as NEEDLE).
| Hwang-2021-60-25 25 bike BICYCLE 오토바이 인공 Man-made 747 | ||
| Hwang-2021-60-26 26 gloves GLOVE 장갑 인공 Man-made 867 | ||
| Hwang-2021-60-27 27 squid 오징어 "자연 | ||
| Hwang-2021-60-27 27 squid SQUID 오징어 "자연 4142 |
There was a problem hiding this comment.
Could you double-check the lines here? I think there is a wrong linebreak. In addition, there seem to be quotation marks added or where they in the original?
There was a problem hiding this comment.
Hmm there is indeed something weird going on here. The formatting issue seems to be in the original as well and the quatation marks most likely appeared automatically because the cell is to be kept intact despite the line break. Since the list is very small, I could remove the line break and quatation marks manually?
| Maciejewski-2016-100-181 181 tend 1 to have an inclination 48.42 0.4 57 60.59 1.78 3.18 4 3 2.01 NA NA 4.77 | ||
| Maciejewski-2016-100-182 182 tend 2 to look after 51.58 0.4 57 60.59 1.78 3.18 4 3 2.01 NA NA 4.77 | ||
| Maciejewski-2016-100-183 183 tense 1 pulled or stretched tightly; taut TIGHT 3053 61.6 0.48 58 14.15 1.15 2.92 6 8 1.68 2.86 3.65 5.32 | ||
| Maciejewski-2016-100-183 183 tense 1 pulled or stretched tightly; taut TENSE 4148 61.6 0.48 58 14.15 1.15 2.92 6 8 1.68 2.86 3.65 5.32 |
There was a problem hiding this comment.
Based on the description, this isn't the emotional quality of being tense.
There was a problem hiding this comment.
I was unsure about this one: the new concept TENSE is classified in Emotions and values but my description also applies to muscular strain and physical states, that's why it felt fitting here. Since it is classified under Emotions and values, would you say physical states should not be mapped?
| Zhong-2024-1286-976 976 PICTURE_495 MultiPic250 2.33713099203137 harbour 碼頭 35.8024691358025 37.037037037037 0 75.865671641791 21.5644878687638 3.23968948855996 189 4.42943654473576 2.27646180417324 61.1940298507463 | ||
| Zhong-2024-1286-977 977 PICTURE_496 MultiPic500 1.75274397220133 circle CIRCLE 1467 圓形 34.5679012345679 55.5555555555556 0 83.5802469135803 17.5918050505988 0.616128463777217 47 1.10150009313535 1.67209785793572 90.1234567901235 | ||
| Zhong-2024-1286-978 978 PICTURE_497 MultiPic500 0 coffin COFFIN 2011 棺材 92.5925925925926 0 1.23456790123457 76.1111111111111 21.9835165521806 2.50480917161875 298 6.983979313922 2.47421626407625 92.5925925925926 | ||
| Zhong-2024-1286-979 979 PICTURE_498 MultiPic250 1.82224004470258 mug BOWL 1530 杯 38.2716049382716 56.7901234567901 0 81.2089552238806 18.1538353184855 2.00039521820388 6055 141.906022636905 3.78211414747907 95.5223880597015 |
There was a problem hiding this comment.
This Chinese gloss is usually mapped to CUP.
|
Thank you for the reviews @AnnikaTjuka and @FredericBlum! I've changed some things according to your comments. Hwang-2021-60 is still a mysterium but I'll try to find out what happened there and set up a separate PR in case something needs to be changed. |
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Thanks, @MiraAhmedovic. This can be merged now.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
This PR adds 22 new concept sets:
Further, some existing entries were remapped to the new concepts (RAISIN from GRAPE, from INK to SQUID).
Hidden characters in
conceptlists.tsv(in the description of MorenoMartinez-2012-360) and Vulic-2020-2244 were removed.Instances of "chalkboard" were added to 3084 BLACKBOARD.
A mapping of "flea" to 2241 WILD CAT was changed to 232 FLEA in Needham-1897-262.
A few previously missed mappings for 3025 BARN OR SHED and 4123 COMPETENCE were added.
Closes #1502.