PHP: Change Project to Laravel Application #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Beyond Code Laravel Websockets project was archived in February 2024 Signed-off-by: Alex Mayer <[email protected]>
taylorsilva
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Beyond Code Laravel Websockets project was archived in February 2024.
I removed the
--coverageflags because they caused errors about a missing driver (probably xdebug).I had considered testing the Laravel framework so there were more tests, but it required extra PHP extensions that were not installed by default. It also gets more commits which would trigger more pipelines.
If we are not interested in testing an actual Laravel application, I could add a small PHP application into the apps directory and write a few tests for it. That way we have more control over changes instead of relying on upstream projects not breaking something.