Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2022.7.1 #134

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Release 2022.7.1 #134

merged 3 commits into from
Jul 22, 2022

Conversation

jrbourbeau
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jrbourbeau jrbourbeau added the automerge Merge the PR when CI passes label Jul 22, 2022
@jrbourbeau jrbourbeau mentioned this pull request Jul 22, 2022
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jrbourbeau
Copy link
Member Author

@jakirkham we're seeing

RuntimeError: Could not download https://pypi.io/packages/source/d/dask/dask-2022.7.1.tar.gz

in CI. Do you know if this download error has popped up in other projects recently?

@jakirkham
Copy link
Member

No clue. Was able to download from that link just now. Maybe a hiccup?

@conda-forge-admin, please restart CI

@jakirkham
Copy link
Member

Interesting. On closer inspection it seem the file it is downloading is empty. Not seeing this with the previous release. Would it be possible to reupload the sdist?

@jakirkham
Copy link
Member

Should add tried to download an sdist from a project that was uploaded a couple mins ago and didn't have this issue. In particular this one

curl -LO https://pypi.io/packages/source/t/tooltime/tooltime-0.2.4.tar.gz

Guessing something didn't work correctly when the dask sdist was uploaded (maybe it got corrupted on PyPI somehow)?

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Jul 22, 2022

On closer inspection it seem the file it is downloading is empty.

Hrm, interesting indeed. When I go to PyPI and download dask-2022.7.1.tar.gz I get a non-empty directory with contents.

Would it be possible to reupload the sdist?

I'm not sure how to do this. Does it mean rereleasing somehow on PyPI?

@jakirkham
Copy link
Member

Yeah there are a number of options. One simple one might be just to delete the sdist and upload it again. Here's the relevant UI

Screen Shot 2022-07-22 at 2 45 09 PM

@jrbourbeau
Copy link
Member Author

What about the "You will not be able to re-upload a new distribution of the same type with the same version number." disclaimer in that warning message? Naively reading that makes me think I may not be able to re-upload dask-2022.7.1.tar.gz

@jakirkham
Copy link
Member

That's unfortunate. I suppose another option would be to delete the release and reupload?

Screen Shot 2022-07-22 at 2 51 07 PM

@jrbourbeau
Copy link
Member Author

Stepping back a bit, I still don't understand why we're getting an empty sdist from https://pypi.io in CI. When I go to PyPI directly the sdist for 2022.7.1 isn't empty. Do you know how pypi.io and pypi.org relate to one another?

@jakirkham
Copy link
Member

jakirkham commented Jul 22, 2022

My understanding is it is suppose to be a redirect. However there may be more going on behind the scenes.

If we don't want to go with the deletion route, would suggest raising an issue on this repo ( https://github.com/pypi/warehouse ). It seems there has been at least one other issue like this in the past ( for example pypi/warehouse#7070 ). Though I don't recall seeing something like this before.

@jrbourbeau
Copy link
Member Author

Yeah, I'm in a bit nervous about the deletion route. My understanding is we generally can't re-upload releases (though I may be wrong about that)

Thanks for pointing me to pypi/warehouse. I went and opened up this issue pypi/infra#104

@jakirkham
Copy link
Member

Should add we can use the URL with hashes in it for the interim (while that upstream issue gets worked through). They are a bit suboptimal as they need regenerating each update, but could be a short-term solution.

@jrbourbeau
Copy link
Member Author

I don't have any objection to temporarily using the pypi.org URL with the hash. I do have to step away from the keyboard for an hour-ish. If you're got bandwidth, feel free to push to this branch. But no worries if you're busy with other things, I can always update things here when I'm back online

recipe/meta.yaml Outdated Show resolved Hide resolved
This is a workaround for an upstream issue with the redirect link.
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jul 22, 2022
recipe/meta.yaml Outdated Show resolved Hide resolved
Template version here to make sure this URL gets fixed in the next release.
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jul 22, 2022
@jakirkham
Copy link
Member

No worries. It is simple to add

Kept it templated so we don't accidentally use the old sdist with a new version number in the next release

@github-actions github-actions bot merged commit 6d1a0ba into conda-forge:main Jul 22, 2022
Comment on lines 8 to +10
source:
url: https://pypi.io/packages/source/d/dask/dask-{{ version }}.tar.gz
sha256: 50ad63035d6429cfa71d4c1832888a668e4260b1ef11163c795edc0ed177b4b3
url: https://files.pythonhosted.org/packages/68/e1/1edb5eeb15f88267075c37ee8c83c4527e462bdea328566c5b1e88db705c/dask-{{ version }}.tar.gz
sha256: a3972489c46456e54070fe140a2178e002c2e96912ed9ef85c3896b74f469194
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed issue ( #135 ) to revert back to the pypi.io URLs

@jrbourbeau
Copy link
Member Author

Thanks @jakirkham!

@jakirkham
Copy link
Member

Happy to help 🙂

Think we are down to the Docker image update 🐳

@jrbourbeau jrbourbeau deleted the 2022.7.1 branch July 23, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants