actually move python*.dll to libpython on windows - #907
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33116684592. Examine the logs at this URL for more detail. |
12fe427 to
5075fb9
Compare
after reversal of the build order, these tests are in the wrong place and only held together by re-injecting the full `python` as a test dep, which also hides problems with the files-based tests.
seen on prior libpython tests (where CMake picked up the wrong executable) ``` -- Found Python: C:/hostedtoolcache/windows/Python/3.14.7/x64/python3.exe (found suitable version "3.14.7", minimum required is "3.14.7") found components: Interpreter Development.Embed ```
5075fb9 to
4a842a4
Compare
mgorny
left a comment
There was a problem hiding this comment.
I'm pretty sure there was no special reason for that. Just a mistake made while splitting them.
|
We should revert this PR. libpython is empty in dev branch and it should be empty because python.exe depends on it. |
It's reverted in #908. For 3.14 and below, |
Yes, but it's going to be odd that libpython had the DLL for previous versions and it doesn't for 3.15+ |
|
If you want to revert this also for 3.14, then fine by me. I was just following your wishes, as well as I could interpret your comments. And you merged this PR, which I think was well-documented in terms of what it does... |
|
Not blaming you here. I just forgot this detail when reviewing this PR. |
Follow-up to #894. I noticed by chance that the
python3.dlletc. did not actually end up inlibpython.That's despite tests to this effect
python-feedstock/recipe/meta.yaml
Lines 372 to 378 in 663c2af
which however got satisfied spuriously by an additional test dependency
python-feedstock/recipe/meta.yaml
Lines 353 to 355 in 663c2af
That dependency is a left-over from the
libpythontests prior to the build order inversion in 636474b. Now those tests make no sense on thelibpythonoutput anymore (causing us to shoehorn the full-fledgedpythonback in to find e.g.Python.hand the executables, which also hides problems with the file-presence tests), so move them topython.