Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sixs_json recipe #26803

Merged
merged 20 commits into from
Sep 2, 2024
Merged

Adding sixs_json recipe #26803

merged 20 commits into from
Sep 2, 2024

Conversation

raphidoc
Copy link
Contributor

@raphidoc raphidoc commented Jun 28, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json) and found some lint.

Here's what I've got...

For recipes/sixs_json:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20, 21, 22]

For recipes/sixs_json:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json) and found it was in an excellent condition.

@raphidoc
Copy link
Contributor Author

raphidoc commented Jun 29, 2024

Hi @conda-forge/staged-recipes , @conda-forge/help-fortran, this is my first conda recipe, Ready for review!

It looks like the build failed for win_64 but I was able to build locally on this platform.

This package includes a scientific Fortran software and a light python wrapper.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@raphidoc
Copy link
Contributor Author

@conda-forge/help-python-c

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sixs_json/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sixs_json/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: generic.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

@raphidoc
Copy link
Contributor Author

Hi @ocefpaf ! When you have some time, can you take a look at this?

@ocefpaf
Copy link
Member

ocefpaf commented Aug 29, 2024

Ironically the Windows Fortran part (the harder to get right) seems to be build fine but failing with a file permission error later at install time:

PermissionError: [WinError 5] Access is denied: 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmp3gipkosy\\input.json'
Failed to remove a temporary file 'C:\Users\VssAdministrator\AppData\Local\Temp\pip-build-tracker-839rn1dm\8f04c964ef75e25d614a1c7a4e5822bcbc6fea9da6db22a3530b94e4' due to PermissionError: [WinError 5] Access is denied: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-839rn1dm\\8f04c964ef75e25d614a1c7a4e5822bcbc6fea9da6db22a3530b94e4'.

Failed to remove a temporary file 'C:\Users\VssAdministrator\AppData\Local\Temp\pip-build-tracker-839rn1dm' due to OSError: [WinError 145] The directory is not empty: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-839rn1dm'.

Not sure what is going on.

@raphidoc
Copy link
Contributor Author

The Python wrapper was installed correctly on Windows using noarch in the meta.yaml (but the Fortran compilation failed on UNIX). So, the easiest way to solve that is to separate the Fortran software and the Python wrapper into two distinct packages.
This recipe will keep the modified 6S software (which has now passed all tests !), and I'll create a new one for the Python wrapper.
Thank you very much for your help. It's much appreciated :)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/j6s/meta.yaml, recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/j6s/meta.yaml:

  • No valid build backend found for Python recipe for package j6s using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [9].

For recipes/sixs_json/meta.yaml:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [9].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/j6s/meta.yaml, recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

@raphidoc
Copy link
Contributor Author

@ocefpaf I've split this into two packages, and all tests have passed now; this is ready for review and merging!

@ocefpaf ocefpaf merged commit 1ecb4a2 into conda-forge:main Sep 2, 2024
5 checks passed
@raphidoc raphidoc deleted the sixs_json branch September 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants