Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cran skeleton update #5617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielnachun
Copy link

Description

The R 4.4 + UCRT migration is now complete for all but one CRAN package (see conda-forge/r-volumodel-feedstock#2), and that failure is not related to the migration. We have a handful of other R packages from GitHub that are not yet migrated, also due to issues unrelated to the migration. I believe we are now in a state where we should update conda skeleton cran so that it generates valid recipes now that this migration is now effectively complete. The specific changes as can been in my commit are as follows:

  • remove the {% set native = 'm2w64-' if win else '' %} Jinja line as we no longer use any m2w64 packages except m2w64-sysroot, and that is handled by conda-smithy, not in the recipe
  • no longer add m2w64-gcc-libs to the dependency list for Windows, as we no longer use this package (see previous point)
  • remove merge_build_host: True on Windows, as this is now irrelevant after the UCRT migration and will actually break the build in many cases
  • Use pkg-config and make on Windows instead of m2-pkg-config and m2-make

I also removed the license_family entry as we no longer use this given that we have SPDX license identifiers now.

I'm not sure if these changes constitute a "significant" change worthy of a news update but I'm happy to add one if needed.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@danielnachun danielnachun requested a review from a team as a code owner February 11, 2025 20:33
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @danielnachun.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1113), and ping the bot to refresh the PR.

@dbast
Copy link
Member

dbast commented Feb 13, 2025

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 13, 2025
Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #5617 will not alter performance

Comparing danielnachun:cran_skeleton_update (78e4f47) with main (e5b060e)

Summary

✅ 5 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants