Fix event poll cursor for multi-page ledgers - #422
Open
TheFaith-Code wants to merge 1 commit into
Open
Conversation
|
@TheFaith-Code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a silent event-loss bug in the event poller used by subscribeToStream.
Summary
switch event polling to use the RPC pagination cursor returned by getEvents
stop deriving the next poll position from the highest ledger in the current page, which could skip remaining events from the same ledger when a page boundary is hit
fall back to latestLedger + 1 when no cursor is returned, so already-seen events are not replayed
add a regression test covering a ledger with more than 100 events across multiple pages to confirm all events are delivered
Testing
npm test -- --run src/tests/events-subscribe.test.ts
Closes #185