Revert moving KMS into CDH#928
Merged
Merged
Conversation
Contributor
This is probably the best approach. I hacked In addition to the revert, we could think about dropping |
Member
Author
|
cc @mkulke |
fitzthum
force-pushed
the
revert-kms
branch
2 times, most recently
from
February 27, 2025 18:27
a7f9fa4 to
96aff63
Compare
mkulke
approved these changes
Mar 7, 2025
mkulke
left a comment
mkulke
left a comment
Contributor
There was a problem hiding this comment.
lgtm. retriggered the failing s390x job
Member
Author
|
Rebasing |
We use the KMS crate outside of the guest-components. Specifically, we use some of this functionality in Trustee as part of resource backends that use KMSes. We could potentially adjust Trustee to import the CDH and use the KMSes from there, but Trustee doesn't need anything else from the CDH. It probably does make sense to have the KMS logic in its own crate, hence revert the change that brough it into the CDH. This reverts commit 3ab8129. Signed-off-by: Tobin Feldman-Fitzthum <tobin@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion here
I also included a commit from #922 so that I could successfully rebuild the lock file. I will drop that soon.
I had to massage a few things with the hub Cargo.toml.
I am open to other approaches here, but I am going to use this locally at least to keep moving on the multi-device work, which requires me to bump guest-components in Trustee.