handle custom templates #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR aims to handle custom templates by updating the renderTemplate function.
- Removed the direct usage of getEnvOrDefault and splitToMapDefaults.
- Added a custom template function map with a placeholder for future custom functions.
Reviewed Changes
| File | Description |
|---|---|
| base-java/ub/ub.go | Updates renderTemplate to support custom template functions |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
base-java/ub/ub.go:139
- Go does not allow named function declarations inside another function. Consider assigning an anonymous function to a variable or moving the buildTemplate function to package scope.
func buildTemplate(writer io.Writer, template template.Template) error{
| @@ -134,25 +134,17 @@ func path(filePath string, operation string) (bool, error) { | |||
| } | |||
|
|
|||
| func renderTemplate(templateFilePath string) error { | |||
| // Define a function map to handle custom template functions | |||
There was a problem hiding this comment.
The updated renderTemplate function no longer parses the template file or returns a value, which could result in runtime errors. Please restore the parsing logic and a return statement to ensure the function completes its intended operation.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Testing