Skip to content

Conversation

snypelife
Copy link

Please prefix all TypeScript pull-requests with [Typescript]

What

Just a one word fix on the migration doc.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@snypelife snypelife requested review from a team as code owners December 16, 2024 18:32
@confluent-cla-assistant
Copy link

Please sign the Contributor License Agreement here before this PR can be approved.
❌ snypelife
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snypelife , LGTM

@rayokota
Copy link
Member

@snypelife , can you sign the CLA?

@snypelife
Copy link
Author

@rayokota hey sorry, I started to but wasn't exactly comfortable with providing that much PII.

I'm okay with this being closed and re-done. I was just reading the docs and figured I'd submit a patch real quick.

Thank you for reaching so quickly though 🙏

@cprovencher cprovencher added rebase and removed rebase labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants