-
Notifications
You must be signed in to change notification settings - Fork 934
V2.12.0b1 Image Build Fixes #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to be a temporary build configuration change to force artifact generation for version v2.12.0b1, bypassing the normal tag-based build triggers. The title explicitly states "DO NOT MERGE" indicating this is for testing purposes only.
- Removes tag-based build conditions from all wheel building jobs
- Hardcodes version string v2.12.0b1-dev1 in packaging commands
- Adds changelog entry for v2.12.0b1 release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
CHANGELOG.md | Adds new version entry for v2.12.0b1 |
.semaphore/semaphore.yml | Removes tag conditions and hardcodes version strings for artifact building |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.semaphore/semaphore.yml
Outdated
- tar cvf confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz wheelhouse/ | ||
- ls -la | ||
- sha256sum confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz | ||
- sha256sum confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz | ||
- cd .. | ||
- artifact push project artifacts/confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz --destination confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz | ||
- artifact push project artifacts/confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz --destination confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded version string 'v2.12.0b1-dev1' creates maintenance burden and potential for inconsistency. Consider using a build parameter or environment variable instead of hardcoding the version in multiple places.
Copilot uses AI. Check for mistakes.
Fixes issues discovered during building the 2.12.0b1 release for tag build paths.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups