-
Notifications
You must be signed in to change notification settings - Fork 933
Update Documentation for Message Object Instantiation #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
| " Instantiate a Message object. This is primarily intended for " | ||
| "testing and mock scenarios (e.g. unit tests). All parameters are optional.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend something like this.
| " Instantiate a Message object. This is primarily intended for " | |
| "testing and mock scenarios (e.g. unit tests). All parameters are optional.\n" | |
| " Instantiate a Message object.\n" | |
| "\n" | |
| " .. warning::" | |
| " This constructor is intended **only for testing and mock scenarios**." | |
| " Do **not** use user instantiated Message object in mainstream APIs or in production." | |
| " Using this constructor outside of test environments may result in" | |
| " unexpected behavior, security issues, or inconsistent application state.\n" | |
| "\n" | |
| " All parameters are optional.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pranavrth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. Just a nit.
|
Check failing build and rebase the PR. |
|
Build failure looks to be unrelated to the change and the kafka resource failed when it should have given a 400 response. Try rerunning as I believe it will pass on second try here. If we see it reocurring we'll need to fix in master branch. |
0a1cce9
|
Yes, it passed after re-running |
pranavrth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!.






Overview
This PR updates the documentation to add guidance around how and when to instantiate a Message object.
Checklist
References
#2128