Skip to content

Conversation

@ojasvajain
Copy link
Member

@ojasvajain ojasvajain commented Nov 19, 2025

Overview

This PR updates the documentation to add guidance around how and when to instantiate a Message object.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?

References

#2128

@ojasvajain ojasvajain marked this pull request as ready for review November 19, 2025 06:53
@ojasvajain ojasvajain requested review from a team and MSeal as code owners November 19, 2025 06:53
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Comment on lines 855 to 856
" Instantiate a Message object. This is primarily intended for "
"testing and mock scenarios (e.g. unit tests). All parameters are optional.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend something like this.

Suggested change
" Instantiate a Message object. This is primarily intended for "
"testing and mock scenarios (e.g. unit tests). All parameters are optional.\n"
" Instantiate a Message object.\n"
"\n"
" .. warning::"
" This constructor is intended **only for testing and mock scenarios**."
" Do **not** use user instantiated Message object in mainstream APIs or in production."
" Using this constructor outside of test environments may result in"
" unexpected behavior, security issues, or inconsistent application state.\n"
"\n"
" All parameters are optional.\n"

Copy link
Member Author

@ojasvajain ojasvajain Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Have incorporated the change.

image

pranavrth
pranavrth previously approved these changes Nov 19, 2025
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Just a nit.

@pranavrth
Copy link
Member

Check failing build and rebase the PR.

@pranavrth pranavrth self-requested a review November 19, 2025 17:25
MSeal
MSeal previously approved these changes Nov 19, 2025
@MSeal
Copy link
Contributor

MSeal commented Nov 19, 2025

Build failure looks to be unrelated to the change and the kafka resource failed when it should have given a 400 response. Try rerunning as I believe it will pass on second try here. If we see it reocurring we'll need to fix in master branch.

@airlock-confluentinc airlock-confluentinc bot dismissed stale reviews from MSeal and pranavrth via 0a1cce9 November 20, 2025 06:29
@sonarqube-confluent
Copy link

@ojasvajain
Copy link
Member Author

Build failure looks to be unrelated to the change and the kafka resource failed when it should have given a 400 response. Try rerunning as I believe it will pass on second try here. If we see it reocurring we'll need to fix in master branch.

Yes, it passed after re-running

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.

@ojasvajain ojasvajain merged commit ece423f into master Nov 20, 2025
3 checks passed
@ojasvajain ojasvajain deleted the update-message-init-doc branch November 20, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants