Skip to content

Narrow notifications to PermissionRequest only#5

Merged
congmnguyen merged 1 commit into
mainfrom
notify-permission-request-only
Feb 25, 2026
Merged

Narrow notifications to PermissionRequest only#5
congmnguyen merged 1 commit into
mainfrom
notify-permission-request-only

Conversation

@congmnguyen
Copy link
Copy Markdown
Owner

Summary

  • Remove Notification hook from WSL2 variant (claude-notify.md) and Stop + Notification hooks from PowerShell variant (claude-notify-powershell.md)
  • Both variants now use PermissionRequest only — balloon tip / toast fires exclusively when Claude is blocked on a permission prompt ("Do you want to proceed?")
  • Updated CLAUDE.md table, key technical details, and setup instructions to match

Test plan

  • Confirm no notification fires when Claude finishes a regular response
  • Confirm notification fires when Claude shows a tool-use permission prompt

Remove Notification (and Stop) hooks from both claude-notify variants so
balloon tips / toasts fire only when Claude is blocked on a permission
prompt ("Do you want to proceed?"), not on every completed response.
Copilot AI review requested due to automatic review settings February 25, 2026 06:54
@congmnguyen congmnguyen merged commit cd9e2e3 into main Feb 25, 2026
3 checks passed
@congmnguyen congmnguyen deleted the notify-permission-request-only branch February 25, 2026 06:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows the Claude Code notification system to use only the PermissionRequest hook, removing the Notification hook from the WSL2 variant and the Stop + Notification hooks from the PowerShell variant. This reduces notification noise by firing notifications exclusively when Claude needs user approval for tool use, rather than on every response completion.

Changes:

  • Updated WSL2 variant documentation to describe PermissionRequest-only behavior
  • Removed Notification hook configuration from WSL2 settings example
  • Updated PowerShell variant documentation to describe PermissionRequest-only behavior
  • Removed Stop and Notification hook configurations from PowerShell settings example
  • Updated CLAUDE.md table and technical details to reflect the narrowed hook usage

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
claude-notify.md Updated documentation and hook configuration to use only PermissionRequest, removing Notification hook
claude-notify-powershell.md Updated documentation and hook configuration to use only PermissionRequest, removing Stop and Notification hooks
CLAUDE.md Updated summary table, technical details, and setup instructions to reflect PermissionRequest-only approach

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants