common: no slirp for podman6 #393
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Packit jobs failed. @containers/packit-build please check. |
lsm5
force-pushed
the
podman6-no-slirp
branch
from
57c62b9 to
92c00a9
Compare
Luap99
added
the
podman 6
lsm5
force-pushed
the
podman6-no-slirp
branch
2 times, most recently
from
db2cffc to
90bb692
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
90bb692 to
49f1c83
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
49f1c83 to
f3f043f
Compare
|
(I didn’t read the changes yet) it looks like this would benefit from rebasing now that #417 is merged. |
Signed-off-by: Lokesh Mandvekar <[email protected]>
rename: systemd.MoveRootlessNetnsSlirpProcessToUserSlice -> systemd.MoveRootlessNetnsProcessToUserSlice . Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
podman6-no-slirp
branch
from
f3f043f to
7fb7ca5
Compare
|
Rebased. Good for another look. Thanks. |
mtrmac
reviewed
Oct 31, 2025
| config2, err := newLocked(&Options{}, &paths{etc: "testdata/containers_default.conf"}) | ||
| // Then | ||
| gomega.Expect(err).ToNot(gomega.HaveOccurred()) | ||
| gomega.Expect(config2.Network.DefaultRootlessNetworkCmd).To(gomega.Equal("slirp4netns")) |
There was a problem hiding this comment.
I think we might still want to retain a test that the option can be changed by a config file — just maybe use a this-is-not-a-valid-command value?
|
Best to proceed with this only after initial obvious removals from Podman repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.