arch/aarch64: use different RAM start addresses #476
+100
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
slp
commented
Nov 28, 2025
slp
commented
For the KernelCopy payload, check that the kernel really fits in memory before copying it. We were counting on guest_mem.write() to fail if the addresses are outside the covered regions, but this may not happen if we've added shared memory regions to the guest memory. Checking against arch_mem_info.ram_last_addr is more reliable. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
aarch64-small-vms
branch
from
59792b6 to
214e62a
Compare
Remove deprecated get_kernel_start and initrd_load_addr methods. Signed-off-by: Sergio Lopez <[email protected]>
Calculate the right place to put the fdt in arch_memory_regions, save the value in ArchMemoryInfo, and deprecate get_fdt_addr(). Signed-off-by: Sergio Lopez <[email protected]>
EDK2 expects RAM to start at 0x4000_0000, and a while ago we decided to make this default for both the EFI and non-EFI flavors. The problem with this approach is that, on aarch64, the Linux kernel expects to be loaded at 0x8000_0000, meaning that region needs to be covered by RAM. For large VMs this isn't a problem but for VMs smaller than 1GB, that region gets uncovered. In theory, we could add another region dedicated to the kernel at 0x8000_0000 and let the rest of RAM start at 0x4000_0000, but this has two problems: - We would be using more RAM than what we were configured to. - It's very hard to find out exactly the size of the kernel region. So, instead, let's go back to use two different start addresses, depending on wether we're booting a firmware or a kernel, but let's do it in a cleaner way, so we don't depend on having an independent flavor. Fixes: containers#460 Signed-off-by: Sergio Lopez <[email protected]>
When booting a firmware, RAM starts at 0x4000_0000, while when doing a direct kernel boot RAM starts at 0x8000_0000. Only write SMBIOS in the former case. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
aarch64-small-vms
branch
from
214e62a to
13f11da
Compare
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.