Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default podman machine list --all-providers to true #25253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/podman/machine/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func init() {
_ = lsCmd.RegisterFlagCompletionFunc(formatFlagName, common.AutocompleteFormat(&entities.ListReporter{}))
flags.BoolVarP(&listFlag.noHeading, "noheading", "n", false, "Do not print headers")
flags.BoolVarP(&listFlag.quiet, "quiet", "q", false, "Show only machine names")
flags.BoolVar(&listFlag.allProviders, "all-providers", false, "Show machines from all providers")
flags.BoolVar(&listFlag.allProviders, "all-providers", true, "Show machines from all providers")
}

func list(cmd *cobra.Command, args []string) error {
Expand Down
5 changes: 3 additions & 2 deletions docs/source/markdown/podman-machine-list.1.md.in
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ environment variable while the machines are running can lead to unexpected behav

## OPTIONS

#### **--all-providers**
#### **--all-providers**=**true|false**

Show machines from all providers
Show machines from all providers.
The default is **true**.

#### **--format**=*format*

Expand Down
6 changes: 6 additions & 0 deletions test/system/015-help.bats
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,13 @@ function check_help() {
is "${lines[0]}" "Manage pods, containers and images" \
"podman $helpopt: first line of output"
done
}

# bats test_tags=ci:parallel
@test "podman machine list --help tests" {
skip_if_remote
run_podman machine list --help
is "$output" ".*--all-providers Show machines from all providers (default true)" "All providers default to true"
}

# vim: filetype=sh