Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5.4] wire up --retry-delay for artifact pull #25364

Open
wants to merge 1 commit into
base: v5.4
Choose a base branch
from
Open

[v5.4] wire up --retry-delay for artifact pull #25364

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #25352

/assign baude

Fixed bug in `podman artifact pull` where the `--retry-delay` value was discarded.

@baude
wire up --retry-delay for artifact pull
73d1e9e 
fixed a bug in the artifact code where --retry-delay was being
discarded.

Fixes: https://issues.redhat.com/browse/RUN-2511

Signed-off-by: Brent Baude <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from baude. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

/approved

@TomSweeneyRedHat
Copy link
Member

Fixes: https://issues.redhat.com/browse/RHEL-80259, https://issues.redhat.com/browse/RHEL-80260

@TomSweeneyRedHat
Copy link
Member

LGTM

@Luap99
Copy link
Member

Luap99 commented Feb 20, 2025

Fixes: https://issues.redhat.com/browse/RHEL-80259, https://issues.redhat.com/browse/RHEL-80260

Well this is the 5.4 branch and AFAIK we only use the 5.4-rhel branch for the RHEL builds so I don't believe this should be called as fixing becuase you need to backport it to the other branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@baude baude

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @TomSweeneyRedHat @Luap99 @baude