[v4.4.1-rhel] Add conditional release-checking system test #26634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately on a number of occasions, Podman has been released officially with a `-dev` suffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests. Ref. original PR: containers#26540 Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
|
Status note: Trying to figure out how to test these changes on RHEL. |
openshift-ci
bot
added
the
approved
|
Status note: Still working on adding a test for these changes on RHEL. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Tested the changes in #26632 and nothing unexpected broke. I think this is as ready as it's going to be. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 25da95a
into
containers:v4.4.1-rhel
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately on a number of occasions, Podman has been released officially with a
-devsuffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests.Ref. original PR: #26540
Note: Backport created with AI assistance.
Does this PR introduce a user-facing change?