-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add /var/lib/containers/storage/ to illegal mount validation. #27218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Due to the virtiofs filesystem limitations, it cannot deal with multiple uids/gids that are required for the container storage. Fixes: containers#27183 Signed-off-by: Lili Nie <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skycastlelily The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
- The `--mount type=artifact` option to `podman create`, `podman run`, and `podman pod create` now mounts artifacts containing a only a single blob as a file at the given destination path if the path does not exist in the image. | ||
- The `podman volume export` command now refuses to export to `STDOUT` if it is a TTY ([#26506](https://github.com/containers/podman/issues/26506)). | ||
- When generating Quadlet units with options known to be problematic when used with Podman, such as `User=`, `Group=`, and `DynamicUser=` in the `[Service]` section of a unit, Quadlet will now warn the user of the potential incompatibility ([#26543](https://github.com/containers/podman/issues/26543)). | ||
- The `podman machine init` command now throws out errors if users try to mount `/var/lib/containers/storage/`, which podman is not able to support, due to virtiofs filesystem limitations with multiple UIDs/GIDs ([#27183](https://github.com/containers/podman/issues/27183)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add a release note here, just in the PR comment is fine.
"/tmp": {}, | ||
"/usr": {}, | ||
"/var": {}, | ||
"/var/lib/containers/storage/": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like our linter is complaining, could you run gofmt and fix the lint issues?
I would think some mention in docs (man-pages) would be a nth. If nothing else, something that says certain paths mounted into machines can be like this ... and maybe, for example in MacOs ... Thanks for the PR! |
Due to the virtiofs filesystem limitations, it cannot deal with multiple uids/gids that are required for the container storage.
Fixes: #27183