-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add libkrun support #679
base: main
Are you sure you want to change the base?
Conversation
initial code to add libkrun support Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@slp could you please help us here? Is the patch good anything missing? |
Hi @dougsland, thanks for working on this. Even though we require the installation of On the other hand, we don't want to default to use |
@@ -0,0 +1,79 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slp this script is updating container config in qm.container (which we require) and also podman. Is that good solution to your eyes (only enable when running it)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think we need to change the runtime globally, but on a per-container basis.
initial code to add libkrun support