-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qm.if: allow qm process to audit and ptrace #718
Conversation
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Reviewer's Guide by SourceryThis pull request modifies the qm.if file to allow the qm process to perform auditing and ptrace operations. The changes involve revisiting the security or permission configuration within qm.if to include the necessary permissions for these functions. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -580,6 +580,24 @@ template(`qm_domain_template',` | |||
') | |||
') | |||
|
|||
# Allow qm_t domain to read auditd.service | |||
interface(`qm_allow_auditd_read',` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NO idea where this one came from?
type qm_t; | ||
') | ||
|
||
allow qm_t qm_t:process ptrace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also want to allow qm_t to ptrace container processes within the QM?
If you really need this, then it should be disabled by default and then wrapped in a boolean to allow it only for short periods of time. I would much prefer to run debuggers and ptrace type commands in the ASIL (unconfined_t) domain then inside of the qm. An ASIL process can ptrace a qm process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhatdan perfect, closing.
Summary by Sourcery
Chores: