Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qm.if: allow qm process to audit and ptrace #718

Closed
wants to merge 1 commit into from
Closed

Conversation

dougsland
Copy link
Collaborator

@dougsland dougsland commented Feb 10, 2025

Summary by Sourcery

Chores:

  • Update qm.if.

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Copy link

sourcery-ai bot commented Feb 10, 2025

Reviewer's Guide by Sourcery

This pull request modifies the qm.if file to allow the qm process to perform auditing and ptrace operations. The changes involve revisiting the security or permission configuration within qm.if to include the necessary permissions for these functions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enable qm process auditing
  • Adjusted configuration to grant audit permission to the qm process
  • Revisited the related security checks to support auditing during process operations
qm.if
Allow qm process ptrace operations
  • Updated the qm.if configuration to permit ptrace calls by the qm process
  • Ensured that the ptrace-related permission and security verification mechanisms align with the desired functionality
qm.if

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dougsland - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -580,6 +580,24 @@ template(`qm_domain_template',`
')
')

# Allow qm_t domain to read auditd.service
interface(`qm_allow_auditd_read',`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO idea where this one came from?

type qm_t;
')

allow qm_t qm_t:process ptrace;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to allow qm_t to ptrace container processes within the QM?

If you really need this, then it should be disabled by default and then wrapped in a boolean to allow it only for short periods of time. I would much prefer to run debuggers and ptrace type commands in the ASIL (unconfined_t) domain then inside of the qm. An ASIL process can ptrace a qm process.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhatdan perfect, closing.

@dougsland dougsland closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants