There would be one case where this wouldn't work

When accumulated_size has just been refreshed to zero. Also check size is greater than zeor to avoid division by zero. Signed-off-by: Eric Curtin <[email protected]>
containers · Feb 10, 2025 · ad4300f · ad4300f
1 parent 738eda2
commit ad4300f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ramalama/http_client.py b/ramalama/http_client.py
@@ -59,7 +59,7 @@ def perform_download(self, file, progress):
         while True:
             data = self.response.read(1024)
             if not data:
-                break
+                return
 
             size = file.write(data)
             if progress:
@@ -69,8 +69,10 @@ def perform_download(self, file, progress):
                     accumulated_size = 0
                     last_update_time = time.time()
 
-        if accumulated_size:
+        if accumulated_size > 0:
             self.update_progress(accumulated_size)
+
+        if progress:
             print("\033[K", end="\r")
 
     def human_readable_time(self, seconds):