On macOS this was returning an incorrect path

[ericcurtin]

$ ramalama --dryrun run granite-code
llama-run -c 2048 --temp 0.8 /path/to/model

At least try and show the correct path.

Summary by Sourcery

Bug Fixes:

• Fix an issue where the model path was incorrect on macOS when running with --dryrun.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request fixes an issue where the model path was hardcoded to /path/to/model when the --dryrun flag was enabled. The change removes this hardcoded path, allowing the program to correctly resolve the model path.

Sequence diagram for model path resolution

sequenceDiagram
    participant Client
    participant ModelManager

    Client->>ModelManager: get_model_path(args)
    alt Before Fix - with --dryrun
        ModelManager-->>Client: Return '/path/to/model'
    else After Fix - with --dryrun
        ModelManager->>ModelManager: exists(args)
        alt Model exists
            ModelManager-->>Client: Return actual model path
        else Model doesn't exist
            ModelManager->>ModelManager: pull(args)
            ModelManager-->>Client: Return downloaded model path
        end
    end

Loading

File-Level Changes

Change	Details	Files
Removed hardcoded model path when using the --dryrun flag.	Removed the conditional statement that returned /path/to/model when args.dryrun was true.	ramalama/model.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Since you've removed the dryrun override, please verify that the behavior during dry runs is still correct on macOS. Double-check that tests (or add tests if needed) cover the scenario to ensure the new logic doesn't affect the expected behavior during a dry run.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericcurtin]

Very tempting to turn off Fedora 42 packit build for a while...

[jhjaggars]

In this case, should we return something that indicates the model doesn't exist in the store already and we'd try to pull it?

[ericcurtin]

I don't think we should pull for "--dryrun", this is kinda just for, please print an approximate "podman run" command, "--dryrun" implies, don't do things like pull.

[rhatdan]

Agreed, nice fix though.

You can actually see the real command by executing ramalama --debug run MODEL.

[rhatdan]

I am not sure if we should print an error in the case that the model does not exists. But I could be swayed either way.

[rhatdan]

LGTM