Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to build RAG versus Docling images #744

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 5, 2025

Summary by Sourcery

Add support for building RAG images.

New Features:

  • Allow building container images with RAG dependencies.

Tests:

  • Updated tests to cover RAG builds.

Copy link
Contributor

sourcery-ai bot commented Feb 5, 2025

Reviewer's Guide by Sourcery

This pull request modifies the build script to allow users to build either a RAG or Docling image. The build script now installs either the docling or torch dependencies based on the image type being built.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added support for building RAG images in addition to Docling images.
  • Added conditional logic to install either docling or torch dependencies.
  • Created a temporary requirements file to exclude docling when building RAG images.
container-images/pragmatic/build_pragmatic.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing or clarifying the use of 'cat /tmp/nodocling.txt' if it's only for debugging purposes, as it might confuse users of the script.
  • Using a hard-coded temporary file like '/tmp/nodocling.txt' could potentially lead to conflicts if multiple processes run in parallel. Consider using a more unique temporary filename or a different approach to filter the requirements to avoid race conditions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit 3477a13 into containers:main Feb 6, 2025
16 of 17 checks passed
${PYTHON_VERSION} pip install torch --extra-index-url https://download.pytorch.org/whl/$1
tmpfile=$(mktemp)
grep -v docling requirements.txt > ${tmpfile}
${PYTHON_VERSION} pip install -r /tmp/nodocling.txt --prefix=/usr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhatdan when this code is executed:

https://github.com/containers/ramalama/actions/runs/13356993323/job/37301130079?pr=831

it complains with this:

  • grep -v docling requirements.txt
  • python3 -m pip install -r /tmp/nodocling.txt --prefix=/usr
    ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/tmp/nodocling.txt'
    Error: building at STEP "RUN sh /tmp/build_pragmatic.sh ${GPU} ${CONTENT}": while running runtime: exit status 1
    Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants