Check if krunkit process is running

[ericcurtin]

The podman machine list technique isn't consisent across podman machine versions.

Summary by Sourcery

Bug Fixes:

• Fixed an issue where the podman machine list technique is not consistent across podman machine versions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR enhances the container_manager logic in ramalama/common.py by adding a subprocess check for the 'krunkit' process. If 'krunkit' is running, the function immediately returns 'podman', mitigating issues caused by inconsistent podman machine listing across versions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Introduced a subprocess call to check for the 'krunkit' process at runtime.	Added a call to subprocess.run with 'pgrep krunkit' to detect if the process is active. Implemented an early return of 'podman' if the krunkit process is found. Updated the container_manager function in common.py to include this check.	ramalama/common.py

Possibly linked issues

• #1234: The PR fixes the issue by checking for the krunkit process directly. This addresses the root cause of the warning appearing incorrectly.
• #0: The PR fixes the issue by checking if the krunkit process is running, which is a more reliable way to detect if a podman machine with libkrun is running.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Wrap the subprocess.run call in a try/except to handle potential exceptions (e.g., FileNotFoundError) if 'pgrep' isn't available.
• Confirm that returning 'podman' immediately when 'krunkit' is running aligns with the intended darwin-specific logic.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (code-quality): We've found these issues:

• Extract code out into function (extract-method)
• Replace if statement with if expression [×2] (assign-if-exp)
• Lift code into else after jump in control flow (reintroduce-else)
• Replace multiple comparisons of same variable with in operator (merge-comparisons)

[rhatdan]

Try first with --all-providers

This should be in newer podman's

[ericcurtin]

Re-opened here #763