Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install llama.cpp for mac and nocontainer tests #792

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Install llama.cpp for mac and nocontainer tests #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,14 @@ jobs:
shell: bash
run: |
sudo apt-get update
sudo apt-get install podman bats bash codespell python3-argcomplete pipx
sudo apt-get install podman bats bash codespell python3-argcomplete pipx git cmake
make install-requirements
git clone https://github.com/ggerganov/llama.cpp
cd llama.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend doing something like:

container-images/scripts/build_llama_and_whisper.sh build

and introduce this "build" or similar argument to build_llama_and_whisper.sh .

Keeping everything on the same version of llama.cpp will help avoid flakey builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at that but the script was pretty focused on dnf install commands, which will not work on Ubuntu.

Lets get this in and then we ca work towards that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as a follow-on:

It's pretty easy to avoid the dnf stuff in that script, if dnf doesn't exist, don't execute that part

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhatdan #794

git submodule update --init --recursive
cmake -B build -DGGML_NATIVE=OFF
cmake --build build --config Release
sudo cmake --install build

- name: Upgrade to podman 5
run: |
Expand Down Expand Up @@ -134,7 +140,7 @@ jobs:
- name: install golang
shell: bash
run: |
brew install go bats bash jq
brew install go bats bash jq llama.cpp
make install-requirements
- name: Run a one-line script
shell: bash
Expand Down
4 changes: 0 additions & 4 deletions test/system/030-run.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ load helpers
}

@test "ramalama run --keepalive" {
# FIXME: the following skips can be removed, once we install llama-run on
# test systems.
skip_if_nocontainer
skip_if_darwin
run_ramalama 124 run --keepalive 1s tiny
}

Expand Down
Loading