Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run and serve arguments for --device and --privileged #809

Merged
merged 3 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ramalama/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,12 @@ def configure_arguments(parser):
help="store AI Models in the specified directory",
)
parser.add_argument("-v", "--version", dest="version", action="store_true", help="show RamaLama version")
# parser.add_argument("--device",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either turn this code on or delete it.

# dest="device",
# action='append',
# type=str,
# # nargs=1,
# help="Device to leak in to the running container")


def configure_subcommands(parser):
Expand Down Expand Up @@ -801,6 +807,11 @@ def _run(parser):
default=config.get('ctx_size', 2048),
help="size of the prompt context (0 = loaded from model)",
)
parser.add_argument("--device",
dest="device",
action='append',
type=str,
help="Device to leak in to the running container")
parser.add_argument("-n", "--name", dest="name", help="name of container in which the Model will be run")
# Disable network access by default, and give the option to pass any supported network mode into
# podman if needed:
Expand All @@ -811,7 +822,12 @@ def _run(parser):
default="none",
help="set the network mode for the container",
)

parser.add_argument(
"--privileged",
dest="privileged",
action="store_true",
help="give extended privileges to container"
)
parser.add_argument("--seed", help="override random seed")
parser.add_argument(
"--temp", default=config.get('temp', "0.8"), help="temperature of the response from the AI model"
Expand Down
12 changes: 5 additions & 7 deletions ramalama/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,11 @@ def setup_container(self, args):
if hasattr(args, "port"):
conman_args += ["-p", f"{args.port}:{args.port}"]

# Check for env var RAMALAMA_DEVICE to explicitly declare the GPU device path
device_override = 0
gpu_device = os.environ.get("RAMALAMA_DEVICE")
if gpu_device:
conman_args += ["--device", gpu_device]
device_override = 1
if device_override != 1:
if args.device:
for device_arg in args.device:
print(device_arg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like debug line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... yes it is... :-)

conman_args += ["--device", device_arg]
else:
if (sys.platform == "darwin" and os.path.basename(args.engine) != "docker") or os.path.exists("/dev/dri"):
conman_args += ["--device", "/dev/dri"]

Expand Down
Loading