Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ramalama labels about the execution on top of container #810

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 13, 2025

Adds new ai.ramalama.* labels helping introspection of other tools of RamaLama containers

  • ai.ramalama.command
  • ai.ramalama.model
  • ai.ramalama.engine
  • ai.ramalama.runtime
  • ai.ramalama.port

fixes #798

Summary by Sourcery

Add labels to the ramalama container to provide information about the execution environment. This includes the command, model, engine, runtime, and port.

New Features:

  • Add ai.ramalama.command, ai.ramalama.model, ai.ramalama.engine, ai.ramalama.runtime, and ai.ramalama.port labels to the ramalama container

Bug Fixes:

  • Resolve issue where ramalama container labels were missing information about the execution environment

Copy link
Contributor

sourcery-ai bot commented Feb 13, 2025

Reviewer's Guide by Sourcery

This pull request adds new labels to the container to provide more information about the execution environment. The new labels are: ai.ramalama.command, ai.ramalama.model, ai.ramalama.engine, ai.ramalama.runtime, and ai.ramalama.port. These labels are added to the container using the --label flag in the docker run command.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new labels to the container to provide more information about the execution environment.
  • Added ai.ramalama.model label.
  • Added ai.ramalama.engine label.
  • Added ai.ramalama.runtime label.
  • Added ai.ramalama.port label.
  • Added ai.ramalama.command label.
ramalama/model.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rhatdan
Copy link
Member

rhatdan commented Feb 13, 2025

LGTM other then code placement. for testing purposes.

@benoitf
Copy link
Contributor Author

benoitf commented Feb 13, 2025

tests are 💚 now

@rhatdan rhatdan merged commit dcabb94 into containers:main Feb 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include extra runtime annotations when running/serving models using containers
2 participants