Feature/notification top left alignment #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orepo chore(deps): update dependency @testing-library/user-event to v14.6.1
…file chore(deps): update dependency chromatic to v11.29.0
…ockfile fix(deps): update dependency use-debounce to v10.0.5
chore(deps): update dependency docker to v2.8.2
…ier-8.x-lockfile chore(deps): update dependency eslint-config-prettier to v8.10.0
Co-authored-by: Kristoffer <[email protected]>
…t-2.x-lockfile chore(deps): update dependency eslint-plugin-import to v2.31.0
…11y-6.x-lockfile chore(deps): update dependency eslint-plugin-jsx-a11y to v6.10.2
…erscore to v6.14.0
…ont-need-lodash-underscore-6.x-lockfile chore(deps): update dependency eslint-plugin-you-dont-need-lodash-underscore to v6.14.0
* fix: set SVG viewport to 24 24 to render correctly * chore: add changeset --------- Co-authored-by: Kathrin Holzmann <[email protected]>
* chore: add description of package * chore: update package.json chore: update package.json * chore: publish new pre-release version * chore: update package.json * chore: remove from ignore list
* chore: update package.json to ignore i18n-utils package * chore: ignore i18n-utils package when generatign releases
chore: disable renovate
* fix(ComponentSource): code block padding * chore: bring latest versions
chore: update icon codemod
docs(icons): add icon component name changes to the migration guide
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* feat: add `GlobeXIcon` & `TrashIcon` * fix: revert TrashIcon change
* feat(usagecount): makes included word switcheable in UsageCount; Fix tooltip type in UsageCard * fix: makes includedLabel string in UsageCount * chore: adds changeset
fix: Makes quota of type string and number []
* refactor: improve types and fix a11y issue * test: add unit tests for Pagination * chore: add changeset * Update .changeset/empty-beds-cheat.md Co-authored-by: Rémy Lenoir <[email protected]> --------- Co-authored-by: Rémy Lenoir <[email protected]>
* feat: use `TrayArrowDown` & `TrayArrowUp`
…n (#3182) * feat: change variants to color for icon usage * feat: add variant to color token util func * feat: add changeset * feat: update badge pkg * feat: change icon color on warning variant * chore: check website build * chore: re run website build
chore: bump estimo to 3.1.1
- Update NotificationItem to always use flex-start alignment - Add alignSelf: 'flex-start' to icon styles for consistent top-left positioning - Add TopLeftAlignment and MultipleLineParagraph stories to showcase the alignment behavior - Ensure all notification elements (icon, title, content, close button) align to top-left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
This PR implements top-left alignment for all elements in the Notification component to ensure consistent visual alignment.
📋 Changes Made
Core Component Updates:
alignItemsto always use'flex-start'for top-left alignmentalignSelf: 'flex-start'to icon styles for consistent positioningStorybook Stories:
🔍 What This Fixes
🧪 Testing
✅ Checklist