Skip to content

Beta: migrate to new Rollup setup #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 5, 2025
Merged

Beta: migrate to new Rollup setup #2717

merged 9 commits into from
Sep 5, 2025

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Aug 20, 2025 •
edited
Loading

  • node v20
  • using the react-native field for exports
  • having the whole build setup (including ts) within rollup

based on our findings in contentful/contentful-batch-libs#913

@axe312ger axe312ger requested a review from a team as a code owner August 20, 2025 14:00
elylucasctfl
elylucasctfl approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@elylucasctfl elylucasctfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a note about updating the version of node ran in circle. If that change requires a reapproval let me know.

package.json
"types": "dist/types/index.d.ts",
"engines": {
"node": ">=18"
"node": ">=20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update the node used in CI here too https://github.com/contentful/contentful-management.js/blob/master/.circleci/config.yml#L10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!!

elylucasctfl
elylucasctfl reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@elylucasctfl elylucasctfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might run a prettier fix on it as well, there were quite a few warnings thrown

@elylucasctfl
Copy link
Contributor

Theres also a strange error happening in CI on builds. Looks like the instance is running out of memory. Does this build locally? If so, is there something you would see that we could do to help?

image

@axe312ger
Copy link
Collaborator Author

Theres also a strange error happening in CI on builds. Looks like the instance is running out of memory. Does this build locally? If so, is there something you would see that we could do to help?
image

No, it does NOT build locally. Super strange, the exact same config builds types in batch libs with ease. I'll check whats happening there!

@axe312ger axe312ger mentioned this pull request Sep 3, 2025
Open
@whitelisab whitelisab merged commit 1400aa8 into beta Sep 5, 2025
6 checks passed
@whitelisab whitelisab deleted the beta-migrate-to-new-rollup-setup branch September 5, 2025 20:54
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 12.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elylucasctfl elylucasctfl elylucasctfl approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @elylucasctfl @whitelisab