DX - 3414-2 - Adding support for removing the MFA from config #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafeeqd959
reviewed
Aug 25, 2025
|
|
||
| // Create export context object | ||
| protected createExportContext(apiKey?: string): Context { |
There was a problem hiding this comment.
What is the use of this context, also why are naming this as export context, is this only used while export content
shafeeqd959
reviewed
Aug 25, 2025
| import { authenticator } from 'otplib'; | ||
| import { MFAConfig, IMFAService } from '../interfaces'; | ||
|
|
||
| export class MFAService implements IMFAService { |
There was a problem hiding this comment.
@cs-raj why dont we move this common MFA utilities into contentstack utilities and use it here and also use it in auth plugin, so that we can avoid redundant validation code.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version bump: done in #2075